Update hterm-umdjs to fix wcnode error #1843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upgrading hterm-umdjs (to 1.1.4) introduced some regressions in Hyper v1.3.2. See #1817. I didn't investigate further to fix regression and prefer to rollback. But feel free to test these regressions on your PR and find a way to fix them. Your issue seem related to #1770 |
|
Sorry, but I have to close this PR. Our plan is to replace Thank you for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Hyper seems to break when running
docker-compose logsin a Vagrant ssh session. (due to the long line of text?)Updating the
hterm-umdjspackage seems to fix the issue.