-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minification bails out for rollup-plugin-commonjs #485
Comments
ok, I was able to narrow this minification problem down. For some reason, when The fix for rollup-plugin-commonjs is simple as highlighted in rollup/rollup-plugin-commonjs#421 However, I suspect this might be a general problem that we should try to fix in ncc instead. thoughts/opinions/concerns? |
Same problem here when the generated bundle includes the |
While working on https://github.com/osdevisnot/klap, I noticed that final bundle is not minified, resulting in larger payloads on install.
Digging this deeper, I narrowed the problem down to
rollup-plugin-commonjs
. The moment this package is used, the final bundle is unminified for some reason.I was able to produce minimal repro of the problem here:
https://github.com/osdevisnot/ncc-minify-repro
I am digging deeper to solve this, but wanted to open issue in case someone else has this figured out already.
The text was updated successfully, but these errors were encountered: