Emit shared libraries along with binary assets

package.json

@@ -31,6 +31,7 @@
     "azure-storage": "^2.10.2",
     "bindings": "^1.3.1",
     "bytes": "^3.0.0",
+    "canvas": "^2.2.0",
     "codecov": "^3.1.0",
     "copy": "^0.3.2",
     "core-js": "^2.5.7",

src/loaders/node-loader.js

@@ -1,5 +1,6 @@
 const { getOptions } = require('loader-utils');
 const getUniqueAssetName = require('../utils/dedupe-names');
+const sharedlibEmit = require('../utils/sharedlib-emit');
 
 module.exports = function (content) {
   if (this.cacheable)
@@ -9,6 +10,7 @@ module.exports = function (content) {
   const options = getOptions(this);
 
   const name = getUniqueAssetName(id, options.assetNames);
+  sharedlibEmit(id, this.emitFile);  
   this.emitFile(name, content);
 
   return 'module.exports = __non_webpack_require__("./' + name + '")';

src/loaders/relocate-loader.js

@@ -8,6 +8,7 @@ const acorn = require('acorn');
 const bindings = require('bindings');
 const getUniqueAssetName = require('../utils/dedupe-names');
 const { getOptions } = require('loader-utils');
+const sharedlibEmit = require('../utils/sharedlib-emit');
 
 // binary support for inlining logic from - node-pre-gyp/lib/pre-binding.js
 function isPregypId (id) {
@@ -143,6 +144,11 @@ module.exports = function (code) {
     if (options.assets[assetPath])
       return "__dirname + '/" + JSON.stringify(options.assets[assetPath]).slice(1, -1) + "'";
 
+    // If the asset is a ".node" binary, then glob for possible shared
+    // libraries that should also be included
+    if (assetPath.endsWith('.node'))
+      sharedlibEmit(assetPath, this.emitFile);
+
     const name = getUniqueAssetName(assetPath, options.assetNames);
     options.assets[assetPath] = name;
 

src/utils/sharedlib-emit.js

@@ -0,0 +1,27 @@
+const os = require('os');
+const path = require('path');
+const fs = require('fs');
+
+let libRegEx;
+switch (os.platform()) {
+  case 'darwin':
+    libRegEx = /\.dylib$/;
+  break;
+  case 'win32':
+    libRegEx = /\.dll$/;
+  break;
+  default:
+    libRegEx = /\.so(\.\d+)?$/;
+}
+
+// helper for emitting the associated shared libraries when a binary is emitted
+module.exports = function (binaryPath, emitFile) {
+  const dir = path.dirname(binaryPath);
+  const files = fs.readdirSync(dir);
+
+  const sharedLibs = files.filter(name => name.match(libRegEx));
+  sharedLibs.forEach(name => {
+    const libPath = path.resolve(dir, name);
+    emitFile(name, fs.readFileSync(libPath));
+  });
+};

test/integration/canvas.js

@@ -0,0 +1,6 @@
+const canvas = require('canvas');
+module.exports = () => {
+  const { createCanvas } = canvas;
+  const c = createCanvas(200, 200);
+  const ctx = c.getContext('2d');
+};