Minification support #105
Merged
Minification support #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 75.36% 75.44% +0.07%
==========================================
Files 7 6 -1
Lines 406 391 -15
==========================================
- Hits 306 295 -11
+ Misses 100 96 -4
Continue to review full report at Codecov.
|
|
@guybedford needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62.
Finally found the right combo of minification options to not get things to break here.
I would have used the Webpack integration of minification, but auth0.js has a very strange bug where terser just returns "undefined" for the source code, which needed a custom workaround (basically just to fallback to unminified when this happens).
This does slow down the tests quite a bit, but I think it is worth it to ensure minification is properly tested. I've left minification off by default though in builds for this reason.