Firebase admin fix #111
Merged
Firebase admin fix #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 75.89% 75.38% -0.51%
==========================================
Files 9 9
Lines 448 451 +3
==========================================
Hits 340 340
- Misses 108 111 +3
Continue to review full report at Codecov.
|
rauchg
reviewed
Dec 5, 2018
| // remove me when node.js makes this the default behavior | ||
| process.on("unhandledRejection", e => { | ||
| throw e; | ||
| }); |
There was a problem hiding this comment.
Where is this coming from? We should always try to handle the promises we create. Agreed that it's a good thing to add as a safeguard
There was a problem hiding this comment.
Good point - I've handled the rejection rather.
There was a problem hiding this comment.
I do like the safeguard. I strongly dislike Node's default mechanism
There was a problem hiding this comment.
Sure added it back too!
guybedford
force-pushed
the
firebase-admin
branch
from
4285ae3 to
0262f52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109, as well as improving the CLI error messages.