fix(deps): update webpack to v5.94.0, terser to v5.33.0

[theoludwig]

Attempt to fix CI, and update webpack and terser to their latest version.

• Fixes Outdated Terser causes a syntax issue when minify-ing code #1193
• Closes fix: upgrade to terser@5.31.0 to fix minfy with negated in statements #1194
• Closes chore(deps-dev): Bump webpack from 5.76.0 to 5.91.0 #1177
• Closes chore(deps-dev): Bump webpack from 5.76.0 to 5.94.0 #1204
• Closes temp ci run #1195

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

[styfle]

Looks like macos is failing to install dependencies.

We might need to update canvas as well.

[theoludwig]

Looks like macos is failing to install dependencies.

We might need to update canvas as well.

Thank you for running CI, and helping for fixing this issue. 😄

I've updated canvas to https://github.com/Automattic/node-canvas/releases/tag/v3.0.0-rc2, hopefully it fixes issues with macOS, but for "Node 20 and ubuntu-latest", it seems like there is another issue.

[styfle]

Looks like updating canvas didn't help. Perhaps we need to install pangocairo maybe others:

Automattic/node-canvas#1050 (comment)

[styfle]

Oh yeah, you can see their CI has it here:

https://github.com/hargasinski/node-canvas/blob/e7abe64833d13ec96449c827b1e14befbdf3105d/.github/workflows/ci.yaml#L68-L70

[styfle]

Are you able to run coverage locally?

The failure makes it seem related to this PR.

  ● should generate correct output for browser-mainfield
    TypeError: Cannot read properties of undefined (reading 'then')
      at node_modules/webpack/lib/FileSystemInfo.js:1908:19
      at processQueue (node_modules/webpack/lib/util/processAsyncTree.js:56:4)

Perhaps you could start with a new PR that doesn't upgrade webpack and only gets CI passing?

[theoludwig]

When I first started this PR, I was able to run yarn test locally without issues, then I focused on the CI problems, and haven't ran tests locally since.
I never tried yarn test-coverage locally, my bad, I should have ran it, it seems like it is also part of the main issue since the beginning.

Perhaps you could start with a new PR that doesn't upgrade webpack and only gets CI passing?

Yeah, that's a good idea, to start simple and "small" as possible. Priority is to first fix CI, then we'll see.
However, I tried rm -rf node_modules .cache tmp, git checkout main, yarn, yarn test, and the same issue seem to appear:

      at node_modules/webpack/lib/FileSystemInfo.js:1676:22
      at processQueue (node_modules/webpack/lib/util/processAsyncTree.js:50:4)
/home/theoludwig/Documents/open-source/ncc/node_modules/webpack/lib/FileSystemInfo.js:1677
							lexer.init.then(() => {
							           ^

TypeError: Cannot read properties of undefined (reading 'then')
    at /home/theoludwig/Documents/open-source/ncc/node_modules/webpack/lib/FileSystemInfo.js:1677:19
    at processQueue (/home/theoludwig/Documents/open-source/ncc/node_modules/webpack/lib/util/processAsyncTree.js:50:4)
    at processTicksAndRejections (node:internal/process/task_queues:77:11)

---

I will check later, when I have time, what could be the root cause of the issue.

[styfle]

Yes, ideally you could run yarn test-coverage locally and not have to wait on me to approve CI. That should help you iterate faster. Thanks for looking into it!

[theoludwig]

Yes, ideally you could run yarn test-coverage locally and not have to wait on me to approve CI. That should help you iterate faster. Thanks for looking into it!

Yep! (was just blindlessly thinking it was only related to CI config problems 😅)

After debugging for a while, I found that the error might be related to a race condition happening when process.exit(0); is called in coverage mode in integration.test.js but watcher.test.js tests are still running.

I first tried to run each test file separately, like: yarn test-coverage test/integration.test.js, yarn test-coverage test/watcher.test.js, etc. And everything was working fine locally.

So I tried with jest --runInBand CLI option, and now yarn test-coverage works locally. The leveldown.js test on macOS still need to be skipped, and OS dependencies still need to be installed.

Just to be 100% sure, that the CI problem is resolved, I enabled GitHub Actions on my fork, and ran it here: https://github.com/theoludwig/ncc/pull/1

And good news, it is working:

The PR is here: #1216
It's focusing only on fixing the CI and tests, when it will be merged, I will update this one, to update webpack and terser (most importantly, terser, if the webpack update doesn't work).

[styfle]

@theoludwig Nice find! 🕵️

The other PR was merged so feel free to update this one, thanks! 🎉

[socket-security]

Report too large to display inline

View full report↗︎

[styfle]

Great work, thanks! 🎉