Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nbind binary support #220

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Nbind binary support #220

merged 1 commit into from
Jan 15, 2019

Conversation

guybedford
Copy link
Contributor

This provides nbind binary asset emission support (just like we do for node-gyp and bindings).

Fixes #132 supporting yoga-layout.

@codecov-io
Copy link

Codecov Report

Merging #220 into master will increase coverage by 1.07%.
The diff coverage is 88.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   68.84%   69.92%   +1.07%     
==========================================
  Files          13       13              
  Lines         597      635      +38     
==========================================
+ Hits          411      444      +33     
- Misses        186      191       +5
Impacted Files Coverage Δ
src/cli.js 0% <ø> (ø) ⬆️
src/loaders/relocate-loader.js 92.33% <88.63%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1099f...aec49aa. Read the comment docs.

@rauchg rauchg merged commit 1987382 into master Jan 15, 2019
@rauchg rauchg deleted the nbind branch January 15, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants