Ensure local TypeScript is always a project-scoped lookup #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
ts-project
branch
from
8865572 to
02b10f5
Compare
guybedford
force-pushed
the
ts-project
branch
from
02b10f5 to
f708c51
Compare
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 69.25% 69.17% -0.09%
==========================================
Files 16 16
Lines 670 665 -5
==========================================
- Hits 464 460 -4
+ Misses 206 205 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the resolution of the local TypeScript lookup to be based on doing a node_modules lookup from the entry point itself of the
nccbuild operation. The previous check would only check for TypeScript once and from the ncc location, therefore using thenpm install -g typescriptinstead of the local project TypeScript.I'm working on a separate PR to add CLI runner coverage, and will include tests for this on that branch.