Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include version in bulid output #281

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Include version in bulid output #281

merged 1 commit into from
Feb 14, 2019

Conversation

guybedford
Copy link
Contributor

This updates the build output to include the version on the last line:

    8kB  dist/puppeteer-core/CONTRIBUTING.md
   11kB  dist/puppeteer-core/LICENSE
   18kB  dist/puppeteer-core/README.md
   87kB  dist/Inter-Regular.woff2
   94kB  dist/Inter-Bold.woff2
  782kB  dist/source/iltorb/build/bindings/iltorb.node
 1157kB  dist/index.js
35035kB  dist/bin/chromium-72.0.3617.0.br
37194kB  [2941ms] ncc - 0.15.0

formatting suggestions welcome too.

@codecov-io
Copy link

Codecov Report

Merging #281 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   66.57%   66.66%   +0.09%     
==========================================
  Files          11       11              
  Lines         350      351       +1     
==========================================
+ Hits          233      234       +1     
  Misses        117      117
Impacted Files Coverage Δ
src/cli.js 62.19% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55aee8e...2fd7ce1. Read the comment docs.

@rauchg rauchg merged commit 803b421 into master Feb 14, 2019
@rauchg rauchg deleted the build-version branch February 14, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants