Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for npm install build #310

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

guybedford
Copy link
Contributor

I've also verified this fails on the 0.1.8 version of the asset relocator loader.

Resolves #308.

@styfle styfle self-requested a review March 14, 2019 15:54
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@a2ea9b4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #310   +/-   ##
=========================================
  Coverage          ?   68.37%           
=========================================
  Files             ?       12           
  Lines             ?      370           
  Branches          ?        0           
=========================================
  Hits              ?      253           
  Misses            ?      117           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ea9b4...2161d9e. Read the comment docs.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 💚

@styfle styfle merged commit 17eb4d8 into master Mar 14, 2019
@styfle styfle deleted the npm-integration branch March 14, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants