Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable minification for sourcemap-register.js #631

Merged
merged 2 commits into from
Dec 24, 2020

Conversation

xom9ikk
Copy link
Contributor

@xom9ikk xom9ikk commented Dec 23, 2020

File scripts/build.js contains invalid configuration for ncc.
Most likely it does not do what was expected. After fixed, the /dist/ncc/sourcemap-register.js.cache.js file becomes minified. And its weight is reduced by 86kb.

File: /dist/ncc/sourcemap-register.js.cache.js
Original size: 127kb
Fixed: 41kb

scripts/build.js Outdated Show resolved Hide resolved
@styfle styfle changed the title Enable minification Enable minification for sourcemap-register.js Dec 24, 2020
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Let's use the existing minify variable like the others above

Co-authored-by: Steven <steven@ceriously.com>
@styfle styfle added the automerge Automatically merge PR once checks pass label Dec 24, 2020
@xom9ikk
Copy link
Contributor Author

xom9ikk commented Dec 24, 2020

@styfle yes you are right!)

@kodiakhq kodiakhq bot merged commit 26222e3 into vercel:master Dec 24, 2020
zeroooooooo added a commit to hitheres/ncc that referenced this pull request Dec 25, 2020
Enable minification for sourcemap-register.js (vercel#631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants