-
Notifications
You must be signed in to change notification settings - Fork 318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the README installation instructions be updated to npm install --save @zeit/next-preact preact
as the preact-compat and preact-context are not used anymore? I can do a PR to your branch if you'd like
Since the changes are approved, can someone merge this? I'm trying to get started with the latest version of Preact right now and this would make that easier. |
I have set up a very similar to this pull request to try Preact 10 with Next.js and have errors with createContext when using react-icons A very minimal repo here: |
Any chance this could be merged? |
Only note from me: it would probably be better to have |
moduleAlias.addAlias('react-dom', 'preact-compat') | ||
moduleAlias.addAlias('react', 'preact/compat') | ||
moduleAlias.addAlias('react-dom', 'preact/compat') | ||
moduleAlias.addAlias('react-ssr-prepass', 'preact-ssr-prepass') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my other comment, I'd prefer preact-ssr-prepass
be a dependency of this plugin rather than being left up to userland.
moduleAlias.addAlias('react-ssr-prepass', 'preact-ssr-prepass') | |
moduleAlias.addAlias('react-ssr-prepass', require.resolve('preact-ssr-prepass')) |
Will this be updated on NPM? I'm still getting the old version of it from the registry. |
Sorry to bump, but as @kennykimjr mentioned, the old version of this plugin is still in the registry. |
Any news on pushing the new version to NPM ? |
Disclaimer: I work on Preact We're getting reports of Preact and hooks not working with nextjs from time to time and they often use We'd be really thankful if the package on npm can be updated. This would save us quite a bit of time when debugging issues related to nextjs. Please publish a new version. |
closes #493
closes #483
refs