This repository has been archived by the owner on Jul 6, 2021. It is now read-only.
Fix sass/scss sourcemaps #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
DenisYaschenko
approved these changes
Dec 20, 2019
DenisYaschenko
approved these changes
Dec 20, 2019
|
Running into the same issue again... @timneutkens Would you be so kind to review (and merge?) this small change? Thank you! |
|
We're not planning to make changes to next-sass as built-in support is landing very soon: vercel/next.js#10134 |
|
Alright, thanks. I've tested the canary-version and sass sourcemaps are working properly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the sass/scss source maps are incorrect. The generated sourcemaps are created after the sass sources have been compiled. This way, the sourcemaps in the build don't show the proper lines in the original .scss / .sass files.
By passing the
sourceMapoption to the sass loader, this should be fixed.