Skip to content

Commit

Permalink
Turbopack issue report tests (#61845)
Browse files Browse the repository at this point in the history
## What?

Currently going through all issues on the Turbo repository to check if
they've been fixed already, this PR adds tests for the reports.

- [x] vercel/turborepo#5913

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-2413
  • Loading branch information
timneutkens authored Feb 10, 2024
1 parent 479faa7 commit 2b7f50f
Show file tree
Hide file tree
Showing 6 changed files with 49 additions and 0 deletions.
10 changes: 10 additions & 0 deletions examples/svg-components/next.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
/** @type {import('next').NextConfig} */
module.exports = {
reactStrictMode: true,
experimental: {
turbo: {
rules: {
"*.svg": {
loaders: ["@svgr/webpack"],
as: "*.js",
},
},
},
},
webpack(config) {
config.module.rules.push({
test: /\.svg$/i,
Expand Down
7 changes: 7 additions & 0 deletions test/e2e/app-dir/turbopack-reports/app/layout.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export default function Root({ children }: { children: React.ReactNode }) {
return (
<html>
<body>{children}</body>
</html>
)
}
3 changes: 3 additions & 0 deletions test/e2e/app-dir/turbopack-reports/app/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default function Page() {
return <p>hello world</p>
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import sqlite3 from 'sqlite3'

export default function Page() {
console.log(sqlite3.READONLY)
return <h1 id="message">Hello World</h1>
}
6 changes: 6 additions & 0 deletions test/e2e/app-dir/turbopack-reports/next.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/**
* @type {import('next').NextConfig}
*/
const nextConfig = {}

module.exports = nextConfig
17 changes: 17 additions & 0 deletions test/e2e/app-dir/turbopack-reports/turbopack-reports.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { createNextDescribe } from 'e2e-utils'

createNextDescribe(
'turbopack-reports',
{
files: __dirname,
dependencies: {
sqlite3: '5.1.7',
},
},
({ next }) => {
it('should render page importing sqlite3', async () => {
const $ = await next.render$('/sqlite-import-5913')
expect($('#message').text()).toBe('Hello World')
})
}
)

0 comments on commit 2b7f50f

Please sign in to comment.