Skip to content

Commit

Permalink
Remove the node-file-trace crate (#70998)
Browse files Browse the repository at this point in the history
### What?

This is a 2nd prefactor for adding node-file-trace into turbopack. When implementing this, we have a few options namely:

- a) expose turbotrace (node-file-trace-rs) as a napi library and try to insert it into the current codebase
- b) expose turbotrace and try to reuse the turbo backend
- c) move turobtrace into the rust process and do it in parallel with everything else

We chose c

We have already ripped out the js code path, this PR nukes the now-orphaned node-file-trace rust binary and napi bindings.

### Why?

The crate is unmaintained and probably will not be used in its current form.
  • Loading branch information
arlyon authored Nov 7, 2024
1 parent fbb3a76 commit 3066987
Show file tree
Hide file tree
Showing 10 changed files with 0 additions and 862 deletions.
22 changes: 0 additions & 22 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ next-custom-transforms = { path = "crates/next-custom-transforms" }

# Turbopack
auto-hash-map = { path = "turbopack/crates/turbo-tasks-auto-hash-map" }
node-file-trace = { path = "turbopack/crates/node-file-trace", default-features = false }
swc-ast-explorer = { path = "turbopack/crates/turbopack-swc-ast-explorer" }
turbo-prehash = { path = "turbopack/crates/turbo-prehash" }
turbo-tasks-malloc = { path = "turbopack/crates/turbo-tasks-malloc", default-features = false }
Expand Down
1 change: 0 additions & 1 deletion crates/napi/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ next-api = { workspace = true }
next-build = { workspace = true }
next-core = { workspace = true }

node-file-trace = { workspace = true, features = ["node-api"] }
mdxjs = { workspace = true, features = ["serializable"] }

turbo-tasks-malloc = { workspace = true, default-features = false, features = [
Expand Down
2 changes: 0 additions & 2 deletions crates/napi/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ pub mod transform;
pub mod turbo_trace_server;
#[cfg(not(target_arch = "wasm32"))]
pub mod turbopack;
#[cfg(not(target_arch = "wasm32"))]
pub mod turbotrace;
pub mod util;

// Declare build-time information variables generated in build.rs
Expand Down
53 changes: 0 additions & 53 deletions crates/napi/src/turbotrace.rs

This file was deleted.

47 changes: 0 additions & 47 deletions turbopack/crates/node-file-trace/Cargo.toml

This file was deleted.

5 changes: 0 additions & 5 deletions turbopack/crates/node-file-trace/build.rs

This file was deleted.

Loading

0 comments on commit 3066987

Please sign in to comment.