remove in turbopack and update tests

vercel · May 13, 2024 · 56d5c21 · 56d5c21
1 parent 0efdfb1
commit 56d5c21
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 23 deletions.
diff --git a/packages/next-swc/crates/next-api/src/project.rs b/packages/next-swc/crates/next-api/src/project.rs
@@ -718,7 +718,6 @@ impl Project {
         // need to confirm what we'll do with turbopack.
         let config = self.next_config();
 
-        emit_event("swcMinify", *config.swc_minify().await?);
         emit_event(
             "skipMiddlewareUrlNormalize",
             *config.skip_middleware_url_normalize().await?,

diff --git a/packages/next-swc/crates/next-core/src/next_config.rs b/packages/next-swc/crates/next-core/src/next_config.rs
@@ -126,7 +126,6 @@ pub struct NextConfig {
     public_runtime_config: IndexMap<String, serde_json::Value>,
     server_runtime_config: IndexMap<String, serde_json::Value>,
     static_page_generation_timeout: f64,
-    swc_minify: Option<bool>,
     target: Option<String>,
     typescript: TypeScriptConfig,
     use_file_system_public_routes: bool,
@@ -535,7 +534,6 @@ pub struct ExperimentalConfig {
     server_minification: Option<bool>,
     /// Enables source maps generation for the server production bundle.
     server_source_maps: Option<bool>,
-    swc_minify: Option<bool>,
     swc_trace_profiling: Option<bool>,
     /// @internal Used by the Next.js internals only.
     trust_host_header: Option<bool>,
@@ -970,11 +968,6 @@ impl NextConfig {
         ))
     }
 
-    #[turbo_tasks::function]
-    pub async fn swc_minify(self: Vc<Self>) -> Result<Vc<bool>> {
-        Ok(Vc::cell(self.await?.swc_minify.unwrap_or(false)))
-    }
-
     #[turbo_tasks::function]
     pub async fn skip_middleware_url_normalize(self: Vc<Self>) -> Result<Vc<bool>> {
         Ok(Vc::cell(

diff --git a/test/development/basic/__snapshots__/next-rs-api.test.ts.snap b/test/development/basic/__snapshots__/next-rs-api.test.ts.snap
@@ -107,13 +107,6 @@ exports[`next.rs api should detect the correct routes: diagnostics 1`] = `
       "swcImportSource": "false",
     },
   },
-  {
-    "category": "NextFeatureTelemetry_category_tbd",
-    "name": "EVENT_BUILD_FEATURE_USAGE",
-    "payload": {
-      "swcMinify": "true",
-    },
-  },
   {
     "category": "NextFeatureTelemetry_category_tbd",
     "name": "EVENT_BUILD_FEATURE_USAGE",

diff --git a/test/integration/telemetry/next.config.swc b/test/integration/telemetry/next.config.swc
@@ -1,5 +1,4 @@
 module.exports = {
-  swcMinify: true,
   compiler: {
     relay: {
       // This should match relay.config.js

diff --git a/test/integration/telemetry/test/config.test.js b/test/integration/telemetry/test/config.test.js
@@ -327,10 +327,6 @@ describe('config telemetry', () => {
               featureName: 'swcLoader',
               invocationCount: 1,
             },
-            {
-              featureName: 'swcMinify',
-              invocationCount: 1,
-            },
             {
               featureName: 'swcRelay',
               invocationCount: 1,

diff --git a/test/production/terser-class-static-blocks/terser-class-static-blocks.test.ts b/test/production/terser-class-static-blocks/terser-class-static-blocks.test.ts
@@ -3,9 +3,7 @@ import { nextTestSetup } from 'e2e-utils'
 describe('terser-class-static-blocks', () => {
   const { next } = nextTestSetup({
     files: __dirname,
-    nextConfig: {
-      swcMinify: false,
-    },
+    nextConfig: {},
   })
 
   it('should work using cheerio', async () => {