Rename waitForAndOpenRuntimeError to openRedbox

vercel · Nov 20, 2024 · bb26a44 · bb26a44
1 parent 065f250
commit bb26a44
Show file tree

Hide file tree

Showing 15 changed files with 78 additions and 93 deletions.
diff --git a/test/development/acceptance-app/ReactRefreshLogBox.test.ts b/test/development/acceptance-app/ReactRefreshLogBox.test.ts
@@ -41,7 +41,7 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
     )
     await session.evaluate(() => document.querySelector('a').click())
 
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
     expect(await session.getRedboxSource()).toMatchSnapshot()
   })
 
@@ -149,7 +149,7 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
       `export default function FunctionDefault() { throw new Error('no'); }`
     )
 
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
     expect(await session.getRedboxSource()).toMatchSnapshot()
     expect(
       await session.evaluate(() => document.querySelector('h2').textContent)
@@ -390,7 +390,7 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
     )
 
     await session.evaluate(() => document.querySelector('button').click())
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     const header = await session.getRedboxDescription()
     expect(header).toMatchSnapshot()
@@ -435,7 +435,7 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
     )
 
     await session.evaluate(() => document.querySelector('button').click())
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     const header2 = await session.getRedboxDescription()
     expect(header2).toMatchSnapshot()
@@ -480,7 +480,7 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
     )
 
     await session.evaluate(() => document.querySelector('button').click())
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     const header3 = await session.getRedboxDescription()
     expect(header3).toMatchSnapshot()
@@ -525,7 +525,7 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
     )
 
     await session.evaluate(() => document.querySelector('button').click())
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     const header4 = await session.getRedboxDescription()
     expect(header4).toEqual(

diff --git a/test/development/acceptance-app/error-message-url.test.ts b/test/development/acceptance-app/error-message-url.test.ts
@@ -49,7 +49,7 @@ describe('Error overlay - error message urls', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     const link = await browser.elementByCss('#nextjs__container_errors__link a')
     const text = await link.text()

diff --git a/test/development/acceptance-app/error-recovery.test.ts b/test/development/acceptance-app/error-recovery.test.ts
@@ -136,7 +136,7 @@ describe.each(['default', 'turbo'])('Error recovery app %s', () => {
       await session.evaluate(() => document.querySelector('p').textContent)
     ).toBe('1')
 
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     expect(await session.getRedboxSource()).toMatchInlineSnapshot(`
       "index.js (7:11) @ Index.useCallback[increment]
@@ -282,7 +282,7 @@ describe.each(['default', 'turbo'])('Error recovery app %s', () => {
     )
 
     await new Promise((resolve) => setTimeout(resolve, 1000))
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
     expect(await session.getRedboxSource()).not.toInclude(
       "Expected '}', got '<eof>'"
     )

diff --git a/test/development/acceptance-app/hydration-error.test.ts b/test/development/acceptance-app/hydration-error.test.ts
@@ -71,7 +71,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(1)
@@ -153,7 +153,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(1)
@@ -203,7 +203,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(1)
@@ -239,7 +239,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(1)
@@ -288,7 +288,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(1)
@@ -330,7 +330,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(1)
@@ -378,7 +378,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(2)
@@ -427,7 +427,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     await retry(async () => {
@@ -489,7 +489,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     const pseudoHtml = await session.getRedboxComponentStack()
     if (isTurbopack) {
@@ -574,7 +574,7 @@ describe('Error overlay for hydration errors in App router', () => {
     )
 
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(2)
@@ -633,7 +633,7 @@ describe('Error overlay for hydration errors in App router', () => {
     )
 
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(2)
@@ -672,7 +672,7 @@ describe('Error overlay for hydration errors in App router', () => {
     )
 
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(2)
@@ -726,7 +726,7 @@ describe('Error overlay for hydration errors in App router', () => {
     )
 
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(2)
@@ -798,7 +798,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
 
@@ -870,7 +870,7 @@ describe('Error overlay for hydration errors in App router', () => {
       ])
     )
     const { session, browser } = sandbox
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     await session.assertHasRedbox()
     expect(await getRedboxTotalErrorCount(browser)).toBe(1)

diff --git a/test/development/acceptance-app/version-staleness.test.ts b/test/development/acceptance-app/version-staleness.test.ts
@@ -45,7 +45,7 @@ describe('Error Overlay version staleness', () => {
       `
     )
 
-    await session.waitForAndOpenRuntimeError()
+    await session.openRedbox()
 
     if (process.env.TURBOPACK) {
       expect(await getStaleness(browser)).toMatchInlineSnapshot(

diff --git a/...pment/app-dir/capture-console-error-owner-stack/capture-console-error-owner-stack.test.ts b/...pment/app-dir/capture-console-error-owner-stack/capture-console-error-owner-stack.test.ts
@@ -6,7 +6,7 @@ import {
   getRedboxTitle,
   getRedboxSource,
   getRedboxTotalErrorCount,
-  waitForAndOpenRuntimeError,
+  openRedbox,
 } from 'next-test-utils'
 
 async function getRedboxResult(browser: any) {
@@ -33,7 +33,7 @@ describe('app-dir - capture-console-error-owner-stack', () => {
     const browser = await next.browser('/browser/event')
     await browser.elementByCss('button').click()
 
-    await waitForAndOpenRuntimeError(browser)
+    await openRedbox(browser)
     await assertHasRedbox(browser)
 
     const result = await getRedboxResult(browser)
@@ -82,8 +82,7 @@ describe('app-dir - capture-console-error-owner-stack', () => {
   it('should capture browser console error in render and dedupe if necessary', async () => {
     const browser = await next.browser('/browser/render')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 
@@ -129,8 +128,7 @@ describe('app-dir - capture-console-error-owner-stack', () => {
   it('should capture browser console error in render and dedupe when multi same errors logged', async () => {
     const browser = await next.browser('/browser/render')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 
@@ -176,8 +174,7 @@ describe('app-dir - capture-console-error-owner-stack', () => {
   it('should capture server replay string error from console error', async () => {
     const browser = await next.browser('/ssr')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 
@@ -223,8 +220,7 @@ describe('app-dir - capture-console-error-owner-stack', () => {
   it('should capture server replay error instance from console error', async () => {
     const browser = await next.browser('/ssr-error-instance')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 
@@ -270,8 +266,7 @@ describe('app-dir - capture-console-error-owner-stack', () => {
   it('should be able to capture rsc logged error', async () => {
     const browser = await next.browser('/rsc')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 

diff --git a/test/development/app-dir/capture-console-error/capture-console-error.test.ts b/test/development/app-dir/capture-console-error/capture-console-error.test.ts
@@ -1,12 +1,11 @@
 import { nextTestSetup } from 'e2e-utils'
 import {
-  assertHasRedbox,
   getRedboxCallStack,
   getRedboxDescription,
   getRedboxTitle,
   getRedboxSource,
   getRedboxTotalErrorCount,
-  waitForAndOpenRuntimeError,
+  openRedbox,
 } from 'next-test-utils'
 
 async function getRedboxResult(browser: any) {
@@ -41,8 +40,7 @@ describe('app-dir - capture-console-error', () => {
     const browser = await next.browser('/browser/event')
     await browser.elementByCss('button').click()
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 
@@ -88,8 +86,7 @@ describe('app-dir - capture-console-error', () => {
   it('should capture browser console error in render and dedupe if necessary', async () => {
     const browser = await next.browser('/browser/render')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 
@@ -135,8 +132,7 @@ describe('app-dir - capture-console-error', () => {
   it('should capture browser console error in render and dedupe when multi same errors logged', async () => {
     const browser = await next.browser('/browser/render')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 
@@ -182,8 +178,7 @@ describe('app-dir - capture-console-error', () => {
   it('should capture server replay string error from console error', async () => {
     const browser = await next.browser('/ssr')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 
@@ -229,8 +224,7 @@ describe('app-dir - capture-console-error', () => {
   it('should capture server replay error instance from console error', async () => {
     const browser = await next.browser('/ssr-error-instance')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 
@@ -276,8 +270,7 @@ describe('app-dir - capture-console-error', () => {
   it('should be able to capture rsc logged error', async () => {
     const browser = await next.browser('/rsc')
 
-    await waitForAndOpenRuntimeError(browser)
-    await assertHasRedbox(browser)
+    await openRedbox(browser)
 
     const result = await getRedboxResult(browser)
 

diff --git a/test/development/app-dir/dynamic-io-dev-cache-scope/dynamic-io-dev-cache-scope.test.ts b/test/development/app-dir/dynamic-io-dev-cache-scope/dynamic-io-dev-cache-scope.test.ts
@@ -1,7 +1,7 @@
 import { nextTestSetup } from 'e2e-utils'
 import {
   getRedboxDescription,
-  waitForAndOpenRuntimeError,
+  openRedbox,
   assertNoRedbox,
   retry,
 } from 'next-test-utils'
@@ -72,15 +72,15 @@ describe('Dynamic IO Dev Errors', () => {
     let desc
 
     const browser = await next.browser('/uncached')
-    await waitForAndOpenRuntimeError(browser)
+    await openRedbox(browser)
     desc = await getRedboxDescription(browser)
 
     expect(desc).toContain(
       'Route "/uncached": A component accessed data, headers, params, searchParams, or a short-lived cache without a Suspense boundary nor a "use cache" above it'
     )
 
     await browser.refresh()
-    await waitForAndOpenRuntimeError(browser)
+    await openRedbox(browser)
     desc = await getRedboxDescription(browser)
 
     expect(desc).toContain(