Make sure to update URL on fallback

vercel · Feb 7, 2020 · cebfcbc · cebfcbc
1 parent d56c583
commit cebfcbc
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/packages/next/next-server/lib/router/router.ts b/packages/next/next-server/lib/router/router.ts
@@ -400,16 +400,14 @@ export default class Router implements BaseRouter {
  return resolve(false)
  }
 
- if (emit) {
- Router.events.emit('beforeHistoryChange', as)
- this.changeState(method, url, addBasePath(as), options)
-
- if (process.env.NODE_ENV !== 'production') {
- const appComp: any = this.components['/_app'].Component
- ;(window as any).next.isPrerendered =
- appComp.getInitialProps === appComp.origGetInitialProps &&
- !(routeInfo.Component as any).getInitialProps
- }
+ Router.events.emit('beforeHistoryChange', as)
+ this.changeState(method, url, addBasePath(as), options)
+
+ if (process.env.NODE_ENV !== 'production') {
+ const appComp: any = this.components['/_app'].Component
+ ;(window as any).next.isPrerendered =
+ appComp.getInitialProps === appComp.origGetInitialProps &&
+ !(routeInfo.Component as any).getInitialProps
  }
 
  this.set(route, pathname, query, as, routeInfo)