fix(turbopack): Enable explicit_resource_management transform (#73802)

vercel · Dec 12, 2024 · d63b909 · d63b909
1 parent 477e1e4
commit d63b909
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 0 deletions.
diff --git a/test/e2e/app-dir/ecmascript-features/app/layout.tsx b/test/e2e/app-dir/ecmascript-features/app/layout.tsx
@@ -0,0 +1,8 @@
+import { ReactNode } from 'react'
+export default function Root({ children }: { children: ReactNode }) {
+  return (
+    <html>
+      <body>{children}</body>
+    </html>
+  )
+}
diff --git a/test/e2e/app-dir/ecmascript-features/app/page.tsx b/test/e2e/app-dir/ecmascript-features/app/page.tsx
@@ -0,0 +1,11 @@
+class Disposer {
+  [Symbol.dispose]() {
+    console.log('Disposed')
+  }
+}
+
+export default function Page() {
+  using _disposer = new Disposer()
+
+  return <p>hello world</p>
+}
diff --git a/test/e2e/app-dir/ecmascript-features/ecmascript-features.test.ts b/test/e2e/app-dir/ecmascript-features/ecmascript-features.test.ts
@@ -0,0 +1,14 @@
+import { nextTestSetup } from 'e2e-utils'
+
+describe('ecmascript-features', () => {
+  const { next } = nextTestSetup({
+    files: __dirname,
+  })
+
+  // In case you need to test the response object
+  it('should work with fetch', async () => {
+    const res = await next.fetch('/')
+    const html = await res.text()
+    expect(html).toContain('hello world')
+  })
+})
diff --git a/test/e2e/app-dir/ecmascript-features/next.config.js b/test/e2e/app-dir/ecmascript-features/next.config.js
@@ -0,0 +1,6 @@
+/**
+ * @type {import('next').NextConfig}
+ */
+const nextConfig = {}
+
+module.exports = nextConfig
diff --git a/turbopack/crates/turbopack-ecmascript/src/parse.rs b/turbopack/crates/turbopack-ecmascript/src/parse.rs
@@ -385,6 +385,8 @@ async fn parse_file_content(
             parsed_program.mutate(swc_core::ecma::lints::rules::lint_to_fold(rules));
             drop(span);
 
+            parsed_program.mutate(swc_core::ecma::transforms::proposal::explicit_resource_management::explicit_resource_management());
+
             let transform_context = TransformContext {
                 comments: &comments,
                 source_map: &source_map,