Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically reload page when editing getStaticProps #13949

Closed
Timer opened this issue Jun 9, 2020 · 1 comment · Fixed by #16744
Closed

Automatically reload page when editing getStaticProps #13949

Timer opened this issue Jun 9, 2020 · 1 comment · Fixed by #16744
Assignees
@ijjk
Milestone
iteration 8

Comments

@Timer
Copy link
Member

Timer commented Jun 9, 2020

Feature request

When getStaticProps is edited, we should do a full refresh of the page.

Currently, we apply an "Fast Refresh" update, but this doesn't actually re-fetch the data. This means the user must manually refresh the page after editing getStaticProps.

We should be smart enough to reload the page when the server-bundle changes but the client-bundle remains the same.
@Timer Timer added this to the backlog milestone Jun 11, 2020
@Timer Timer modified the milestones: backlog, iteration 6, iteration 7 Aug 3, 2020
@Timer Timer added the point: 5 label Aug 12, 2020
@Timer Timer modified the milestones: iteration 7, 9.x.x, iteration 8 Aug 18, 2020
@ijjk ijjk mentioned this issue Sep 1, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #16744 Sep 2, 2020
kodiakhq bot pushed a commit that referenced this issue Sep 2, 2020
@ijjk
Add automatic reloading when editing GS(S)P methods (#16744)
4685332 
This adds initial support for reloading the page when `getStaticProps`, `getStaticPaths`, or `getServerSideProps` were changed for a page by triggering a reload when the server output for a page has changed but the client output has not since these methods aren't included in the client output. 

Closes: #13949
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this issue Sep 26, 2020
@ijjk
Add automatic reloading when editing GS(S)P methods (vercel#16744)
f8daa04 
This adds initial support for reloading the page when `getStaticProps`, `getStaticPaths`, or `getServerSideProps` were changed for a page by triggering a reload when the server output for a page has changed but the client output has not since these methods aren't included in the client output. 

Closes: vercel#13949
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
iteration 8
Development

Successfully merging a pull request may close this issue.

Add automatic reloading when editing GS(S)P methods ijjk/next.js
3 participants
@Timer @balazsorban44 @ijjk