Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asPath does not contain trailing slash when enabled during prerendering #22747

Closed
ijjk opened this issue Mar 3, 2021 · 1 comment · Fixed by #22746
Closed

asPath does not contain trailing slash when enabled during prerendering #22747

ijjk opened this issue Mar 3, 2021 · 1 comment · Fixed by #22746
Assignees
@ijjk
Milestone
iteration 17

Comments

@ijjk
Copy link
Member

ijjk commented Mar 3, 2021

We need to ensure the asPath value used during prerendering/auto-export contains a trailing slash when trailingSlash: true is configured to prevent a hydration mis-match.
@ijjk ijjk self-assigned this Mar 3, 2021
@ijjk ijjk mentioned this issue Mar 3, 2021
Merged
@timneutkens timneutkens added this to the 10.x.x milestone Mar 4, 2021
@kodiakhq kodiakhq bot closed this as completed in #22746 Mar 14, 2021
@Timer Timer modified the milestones: 10.x.x, iteration 17 Mar 14, 2021
kodiakhq bot pushed a commit that referenced this issue Mar 14, 2021
@ijjk
Ensure i18n index prefetch is correct with trailingSlash (#22746)
9afcdfc 
This fixes index data route loading for i18n with `trailingSlash: true` enabled and also fixes prerendering `asPath` values not containing a trailingSlash when enabled. 


Fixes: #17813
Fixes: #22747
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
iteration 17
Development

Successfully merging a pull request may close this issue.

Ensure i18n index prefetch is correct with trailingSlash ijjk/next.js
4 participants
@Timer @timneutkens @balazsorban44 @ijjk