Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/Image with grayscale color mode #23625

Closed
samueldelaporte opened this issue Apr 1, 2021 · 4 comments
Closed

Next/Image with grayscale color mode #23625

samueldelaporte opened this issue Apr 1, 2021 · 4 comments
Labels
Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.).
Milestone

Comments

@samueldelaporte
Copy link

Component Next/Image seems to have render problems with pictures in grayscale color mode.

Here is a reproductible bug from a minimalist next-react-app project :
https://github.com/samueldelaporte/test-next-image-grayscale

@Timer Timer transferred this issue from vercel/vercel Apr 2, 2021
@Timer Timer added kind: bug Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.). labels Apr 2, 2021
@samcx
Copy link
Member

samcx commented Apr 2, 2021

This was improved with #23393, but it still needs to be improved.

Here's the image on stable (10.1.2) →

image

Here's the image on canary (10.1.3-canary.1) →

image (1)

@samcx samcx closed this as completed Apr 2, 2021
@Timer Timer added this to the Iteration 18 milestone Apr 2, 2021
@samcx samcx reopened this Apr 2, 2021
@timneutkens timneutkens modified the milestones: Iteration 18, Iteration 19 Apr 8, 2021
@rishi-raj-jain
Copy link

Is this an issue anymore? I deployed the example by @samueldelaporte @ https://test-next-image-grayscale.vercel.app/, and the issue doesn't seem to be there.

@samueldelaporte
Copy link
Author

Fine by me !
I guess it can be closed

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.).
Projects
None yet
Development

No branches or pull requests

6 participants