-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update decoder to correctly handle grayscale PNGs #23393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuding
requested review from
divmain,
ijjk,
lfades and
timneutkens
as code owners
March 25, 2021 13:54
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.88 | 1.908 | |
/ avg req/sec | 1330.03 | 1310.41 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.135 | 1.171 | |
/error-in-render avg req/sec | 2202.48 | 2135.57 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
677f882d2ed8..7edd.js gzip | 13.4 kB | 13.4 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 7.12 kB | 7.12 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 60.2 kB | 60.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
_app-8fbabfc..6440.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-af59f..582f.js gzip | 3.46 kB | 3.46 kB | ✓ |
amp-9716187d..0aa8.js gzip | 536 B | 536 B | ✓ |
hooks-107e90..74c7.js gzip | 888 B | 888 B | ✓ |
index-ac435c..ecf2.js gzip | 227 B | 227 B | ✓ |
link-c31053f..c329.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..dc9d.js gzip | 303 B | 303 B | ✓ |
withRouter-6..0e02.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.64 kB | 8.64 kB | ✓ |
Client Build Manifests
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
_buildManifest.js gzip | 370 B | 370 B | ✓ |
Overall change | 370 B | 370 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
index.html gzip | 613 B | 613 B | ✓ |
link.html gzip | 621 B | 621 B | ✓ |
withRouter.html gzip | 608 B | 608 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
buildDuration | 12.4s | 12.6s | |
nodeModulesSize | 45.9 MB | 45.9 MB | -2.11 kB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
677f882d2ed8..7edd.js gzip | 13.4 kB | 13.4 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 7.12 kB | 7.12 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 60.2 kB | 60.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
_app-8fbabfc..6440.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-af59f..582f.js gzip | 3.46 kB | 3.46 kB | ✓ |
amp-9716187d..0aa8.js gzip | 536 B | 536 B | ✓ |
hooks-107e90..74c7.js gzip | 888 B | 888 B | ✓ |
index-ac435c..ecf2.js gzip | 227 B | 227 B | ✓ |
link-c31053f..c329.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..dc9d.js gzip | 303 B | 303 B | ✓ |
withRouter-6..0e02.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.64 kB | 8.64 kB | ✓ |
Client Build Manifests
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
_buildManifest.js gzip | 370 B | 370 B | ✓ |
Overall change | 370 B | 370 B | ✓ |
Serverless bundles
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
_error.js | 1.36 MB | 1.36 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
500.html | 2.65 kB | 2.65 kB | ✓ |
amp.amp.html | 10.7 kB | 10.7 kB | ✓ |
amp.html | 1.86 kB | 1.86 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1.36 MB | 1.36 MB | ✓ |
link.js | 1.42 MB | 1.42 MB | ✓ |
routerDirect.js | 1.41 MB | 1.41 MB | ✓ |
withRouter.js | 1.41 MB | 1.41 MB | ✓ |
Overall change | 6.99 MB | 6.99 MB | ✓ |
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
buildDuration | 12.9s | 12.9s | |
nodeModulesSize | 45.9 MB | 45.9 MB | -2.11 kB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.844 | 1.909 | |
/ avg req/sec | 1355.71 | 1309.7 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.149 | 1.18 | |
/error-in-render avg req/sec | 2176.03 | 2119.52 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
597-e27c5352..db8c.js gzip | 13.3 kB | 13.3 kB | ✓ |
778-84582755..aa9b.js gzip | 7.05 kB | 7.05 kB | ✓ |
framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 151 B | 151 B | ✓ |
webpack-HASH.js gzip | 993 B | 993 B | ✓ |
Overall change | 60.8 kB | 60.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
_app-5cc66b2..6f03.js gzip | 1.3 kB | 1.3 kB | ✓ |
_error-b58c1..9b8e.js gzip | 3.4 kB | 3.4 kB | ✓ |
amp-89a5460c..567f.js gzip | 558 B | 558 B | ✓ |
hooks-8c2e74..be37.js gzip | 924 B | 924 B | ✓ |
index-fec729..83b2.js gzip | 243 B | 243 B | ✓ |
link-dd34d9b..0ade.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..5759.js gzip | 336 B | 336 B | ✓ |
withRouter-1..98bf.js gzip | 334 B | 334 B | ✓ |
Overall change | 8.76 kB | 8.76 kB | ✓ |
Client Build Manifests
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
_buildManifest.js gzip | 349 B | 349 B | ✓ |
Overall change | 349 B | 349 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
index.html gzip | 610 B | 610 B | ✓ |
link.html gzip | 615 B | 615 B | ✓ |
withRouter.html gzip | 605 B | 605 B | ✓ |
Overall change | 1.83 kB | 1.83 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "wqjH4nUCVIsmExX2SLVvI",
+ "buildId": "k1gNU7IsVUS5dZfcBcDaj",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/wqjH4nUCVIsmExX2SLVvI/_buildManifest.js"
+ src="/_next/static/k1gNU7IsVUS5dZfcBcDaj/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/wqjH4nUCVIsmExX2SLVvI/_ssgManifest.js"
+ src="/_next/static/k1gNU7IsVUS5dZfcBcDaj/_ssgManifest.js"
async=""
></script>
</body>
Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "wqjH4nUCVIsmExX2SLVvI",
+ "buildId": "k1gNU7IsVUS5dZfcBcDaj",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/wqjH4nUCVIsmExX2SLVvI/_buildManifest.js"
+ src="/_next/static/k1gNU7IsVUS5dZfcBcDaj/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/wqjH4nUCVIsmExX2SLVvI/_ssgManifest.js"
+ src="/_next/static/k1gNU7IsVUS5dZfcBcDaj/_ssgManifest.js"
async=""
></script>
</body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "wqjH4nUCVIsmExX2SLVvI",
+ "buildId": "k1gNU7IsVUS5dZfcBcDaj",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/wqjH4nUCVIsmExX2SLVvI/_buildManifest.js"
+ src="/_next/static/k1gNU7IsVUS5dZfcBcDaj/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/wqjH4nUCVIsmExX2SLVvI/_ssgManifest.js"
+ src="/_next/static/k1gNU7IsVUS5dZfcBcDaj/_ssgManifest.js"
async=""
></script>
</body>
timneutkens
approved these changes
Apr 1, 2021
Timer
approved these changes
Apr 1, 2021
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall increase ✓
Client Bundles (main, webpack, commons)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Serverless bundles
Webpack 5 Mode (Increase detected
|
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
buildDuration | 13.1s | 13.3s | |
nodeModulesSize | 45.9 MB | 45.9 MB | -2.11 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.986 | 1.933 | -0.05 |
/ avg req/sec | 1258.65 | 1293.63 | +34.98 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.234 | 1.237 | 0 |
/error-in-render avg req/sec | 2025.66 | 2020.47 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
597-e27c5352..db8c.js gzip | 13.3 kB | 13.3 kB | ✓ |
778-84582755..aa9b.js gzip | 7.05 kB | 7.05 kB | ✓ |
framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 151 B | 151 B | ✓ |
webpack-HASH.js gzip | 993 B | 993 B | ✓ |
Overall change | 60.8 kB | 60.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
_app-5cc66b2..6f03.js gzip | 1.3 kB | 1.3 kB | ✓ |
_error-b58c1..9b8e.js gzip | 3.4 kB | 3.4 kB | ✓ |
amp-89a5460c..567f.js gzip | 558 B | 558 B | ✓ |
hooks-8c2e74..be37.js gzip | 924 B | 924 B | ✓ |
index-fec729..83b2.js gzip | 243 B | 243 B | ✓ |
link-dd34d9b..0ade.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..5759.js gzip | 336 B | 336 B | ✓ |
withRouter-1..98bf.js gzip | 334 B | 334 B | ✓ |
Overall change | 8.76 kB | 8.76 kB | ✓ |
Client Build Manifests
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
_buildManifest.js gzip | 349 B | 349 B | ✓ |
Overall change | 349 B | 349 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | shuding/next.js fix-png-decoder | Change | |
---|---|---|---|
index.html gzip | 610 B | 610 B | ✓ |
link.html gzip | 615 B | 615 B | ✓ |
withRouter.html gzip | 605 B | 605 B | ✓ |
Overall change | 1.83 kB | 1.83 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "K5VDmRqZ0igY9KvZ2kxa_",
+ "buildId": "ivEA6huIgBiAWjRioZ9Ea",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/K5VDmRqZ0igY9KvZ2kxa_/_buildManifest.js"
+ src="/_next/static/ivEA6huIgBiAWjRioZ9Ea/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/K5VDmRqZ0igY9KvZ2kxa_/_ssgManifest.js"
+ src="/_next/static/ivEA6huIgBiAWjRioZ9Ea/_ssgManifest.js"
async=""
></script>
</body>
Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "K5VDmRqZ0igY9KvZ2kxa_",
+ "buildId": "ivEA6huIgBiAWjRioZ9Ea",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/K5VDmRqZ0igY9KvZ2kxa_/_buildManifest.js"
+ src="/_next/static/ivEA6huIgBiAWjRioZ9Ea/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/K5VDmRqZ0igY9KvZ2kxa_/_ssgManifest.js"
+ src="/_next/static/ivEA6huIgBiAWjRioZ9Ea/_ssgManifest.js"
async=""
></script>
</body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "K5VDmRqZ0igY9KvZ2kxa_",
+ "buildId": "ivEA6huIgBiAWjRioZ9Ea",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/K5VDmRqZ0igY9KvZ2kxa_/_buildManifest.js"
+ src="/_next/static/ivEA6huIgBiAWjRioZ9Ea/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/K5VDmRqZ0igY9KvZ2kxa_/_ssgManifest.js"
+ src="/_next/static/ivEA6huIgBiAWjRioZ9Ea/_ssgManifest.js"
async=""
></script>
</body>
ijjk
approved these changes
Apr 1, 2021
SokratisVidros
pushed a commit
to SokratisVidros/next.js
that referenced
this pull request
Apr 20, 2021
This PR updates the Squoosh PNG decoder, which fixes vercel#22929 in GoogleChromeLabs/squoosh#971. ## Bug - [x] Fixes vercel#22929 - [x] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Apr 29, 2021
This PR updates the Squoosh PNG decoder, which fixes vercel#22929 in GoogleChromeLabs/squoosh#971. ## Bug - [x] Fixes vercel#22929 - [x] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Squoosh PNG decoder, which fixes #22929 in GoogleChromeLabs/squoosh#971.
Bug
Feature
fixes #number
Documentation / Examples