Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in server compilation result in a 404 instead of showing the error overlay #24056

Closed
timneutkens opened this issue Apr 14, 2021 · 1 comment · Fixed by #24331
Closed

Errors in server compilation result in a 404 instead of showing the error overlay #24056

timneutkens opened this issue Apr 14, 2021 · 1 comment · Fixed by #24331
Assignees
@shuding
Milestone
Iteration 19

Comments

@timneutkens
Copy link
Member

What version of Next.js are you using?

next@canary

What version of Node.js are you using?

latest

What browser are you using?

Chrome

What operating system are you using?

macOS

How are you deploying your application?

Does not affect this bug

Describe the Bug

Recently found an edge case where if the server compilation fails we'll render a 404 page instead of showing the error overlay. This is obviously not what we'd want. It was surfaced in rauchg's blog and I've opened a PR with a failing test here: #24054

Expected Behavior

The webpack error is surfaced instead of showing a 404 page

To Reproduce

A reproduction is provided as as failing test in #24054
@timneutkens timneutkens added bug Issue was opened via the bug report template. kind: bug and removed bug Issue was opened via the bug report template. labels Apr 14, 2021
@timneutkens timneutkens added this to the Iteration 19 milestone Apr 14, 2021
@timneutkens timneutkens mentioned this issue Apr 14, 2021
Closed
8 tasks
@shuding shuding self-assigned this Apr 16, 2021
@shuding shuding mentioned this issue Apr 21, 2021
Merged
8 tasks
@kodiakhq kodiakhq bot closed this as completed in #24331 Apr 22, 2021
kodiakhq bot pushed a commit that referenced this issue Apr 22, 2021
@shuding
Fix not exposing server errors in hot reloader (#24331)
6cd1c87 
Fixes #24056.

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuding shuding

Labels
None yet
Projects
None yet
Milestone
Iteration 19
Development

Successfully merging a pull request may close this issue.

Fix not exposing server errors in hot reloader shuding/next.js
3 participants
@shuding @timneutkens @balazsorban44