-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Number Type for next/link children #37981
Comments
IMHO it is a bug (not a missing feature). I have opened PR #38013 to fix it. |
…38013) ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes #37981. When handling the legacy link behavior on the current version of Next.js, it only wraps single string child in `<a>` tag. The PR fixes the issue by also wrap single number child in `<a>` tag, too.
@SukkaW Thanks for your PR. I was about to create the PR to fix it, so I raised this issue to check if it is bug or not before creating PR. I wish you would have asked first before taking this issue. I feel like my all efforts and time to find the bug have been wasted. |
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Describe the feature you'd like to request
I think it would be better to support the
number
type for next/link children.Can I open a PR to support it if it's okay with you? :)
Describe the solution you'd like
Describe alternatives you've considered
Add a condition to check the type of children
The text was updated successfully, but these errors were encountered: