Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: README for eslint-config-next just to link to ESLint rules #50843

Open
sm-kc opened this issue Jun 6, 2023 · 6 comments
Open

Docs: README for eslint-config-next just to link to ESLint rules #50843

sm-kc opened this issue Jun 6, 2023 · 6 comments
Labels
Documentation Related to Next.js' official documentation. Linting Related to `next lint` or ESLint with Next.js.

Comments

@sm-kc
Copy link

sm-kc commented Jun 6, 2023

What is the improvement or update you wish to see?

This is a very minor thing. As a brand new user of Next.js, I saw that it comes with an ESLint configuration, so from habit I went to its package page. However eslint-config-next doesn't have a README so that was a dead end. It would have saved me having to go search for the docs page (linked below) if there had been a README with a link to it.

Is there any context that might help us understand?

Just smoothing the path for new users of Next.js who don't know their way around the Next.js docs.

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/pages/building-your-application/configuring/eslint

DX-1696

@sm-kc sm-kc added the Documentation Related to Next.js' official documentation. label Jun 6, 2023
@JesseKoldewijn
Copy link
Contributor

I agree that there should be a README but to be fair, the docs does include all the details about the eslint-config-next package.

@manovotny
Copy link
Contributor

Good suggestion @sm-kc. I created a PR to add a README (#51059). However, it's sister package, eslint-plugin-next already has a README and it doesn't show up on NPM.

@ijjk @timneutkens @styfle is there any way we can get these READMEs published with the package so NPM can link to the documentation?

@styfle
Copy link
Member

styfle commented Jun 9, 2023

However, it's sister package, eslint-plugin-next already has a README and it doesn't show up on NPM.

That's because its no longer maintained. It hasn't been published in 3 years as seen on the Versions tab.

Looks like it was renamed to @next/eslint-plugin-next in package.json

@manovotny
Copy link
Contributor

That's because its no longer maintained. It hasn't been published in 3 years as seen on the Versions tab.

@styfle should we run npm deprecate <package-spec> <message> on eslint-plugin-next then and have the message point to @next/eslint-plugin-next? That would automatically put at banner on top of NPM's page.

@styfle
Copy link
Member

styfle commented Jun 9, 2023

@manovotny Its not owned by Next.js

You'll have to talk to @Timer to add a deprecation message

image

ijjk added a commit that referenced this issue Jun 13, 2023
Fixes (partially) #50843.

---------

Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@balazsorban44 balazsorban44 added Linting Related to `next lint` or ESLint with Next.js. linear: dx labels Jun 26, 2023
@scottdotweb
Copy link

Commenting to take ownership, @sm-kc was my account at a former employer.

@samcx samcx removed the linear: dx label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation. Linting Related to `next lint` or ESLint with Next.js.
Projects
None yet
Development

No branches or pull requests

7 participants