Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating incorrect paths on assembly #58244

Closed
1 task done
alexop1000 opened this issue Nov 9, 2023 · 13 comments · Fixed by #60116
Closed
1 task done

Generating incorrect paths on assembly #58244

alexop1000 opened this issue Nov 9, 2023 · 13 comments · Fixed by #60116
Labels
bug Issue was opened via the bug report template. locked

Comments

@alexop1000
Copy link

alexop1000 commented Nov 9, 2023 •
edited
Loading

Link to the code that reproduces this issue

https://github.com/alexop1000/nextjs-issue-reproduction/tree/master

To Reproduce

  1. Build your next application on Windows (npm run build)
  2. Build the docker image (for example, docker build --pull --rm -f "Dockerfile" -t nexttest:latest ".")
  3. Run the docker image on a Linux machine, or on Docker desktop.

Current vs. Expected behavior

The user gets an internal error 500 when visiting your website. You get "Error: Cannot find module 'next/dist\client\components\static-generation-async-storage-external.js'" on server logs. The specifics can be found in this discussion.
Example error message output:

2023-11-09 10:52:50  ⨯ Error: Cannot find module 'next/dist\client\components\static-generation-async-storage.external.js'
2023-11-09 10:52:50 Require stack:
2023-11-09 10:52:50 - /usr/src/app/.next/server/app/_not-found.js
2023-11-09 10:52:50 - /usr/src/app/node_modules/next/dist/server/require.js
2023-11-09 10:52:50 - /usr/src/app/node_modules/next/dist/server/next-server.js
2023-11-09 10:52:50 - /usr/src/app/node_modules/next/dist/server/next.js
2023-11-09 10:52:50 - /usr/src/app/node_modules/next/dist/server/lib/start-server.js
2023-11-09 10:52:50 - /usr/src/app/node_modules/next/dist/cli/next-start.js
2023-11-09 10:52:50 - /usr/src/app/node_modules/next/dist/lib/commands.js
2023-11-09 10:52:50 - /usr/src/app/node_modules/next/dist/bin/next
2023-11-09 10:52:50     at Module._resolveFilename (node:internal/modules/cjs/loader:1048:15)
2023-11-09 10:52:50     at /usr/src/app/node_modules/next/dist/server/require-hook.js:54:36
2023-11-09 10:52:50     at Module._load (node:internal/modules/cjs/loader:901:27)
2023-11-09 10:52:50     at Module.require (node:internal/modules/cjs/loader:1115:19)
2023-11-09 10:52:50     at mod.require (/usr/src/app/node_modules/next/dist/server/require-hook.js:64:28)
2023-11-09 10:52:50     at require (node:internal/modules/helpers:130:18)
2023-11-09 10:52:50     at 5319 (/usr/src/app/.next/server/app/_not-found.js:1:612)
2023-11-09 10:52:50     at t (/usr/src/app/.next/server/webpack-runtime.js:1:127)
2023-11-09 10:52:50     at 2564 (/usr/src/app/.next/server/chunks/349.js:1:117695)
2023-11-09 10:52:50     at t (/usr/src/app/.next/server/webpack-runtime.js:1:127) {
2023-11-09 10:52:50   code: 'MODULE_NOT_FOUND',
2023-11-09 10:52:50   requireStack: [
2023-11-09 10:52:50     '/usr/src/app/.next/server/app/_not-found.js',
2023-11-09 10:52:50     '/usr/src/app/node_modules/next/dist/server/require.js',
2023-11-09 10:52:50     '/usr/src/app/node_modules/next/dist/server/next-server.js',
2023-11-09 10:52:50     '/usr/src/app/node_modules/next/dist/server/next.js',
2023-11-09 10:52:50     '/usr/src/app/node_modules/next/dist/server/lib/start-server.js',
2023-11-09 10:52:50     '/usr/src/app/node_modules/next/dist/cli/next-start.js',
2023-11-09 10:52:50     '/usr/src/app/node_modules/next/dist/lib/commands.js',
2023-11-09 10:52:50     '/usr/src/app/node_modules/next/dist/bin/next'
2023-11-09 10:52:50   ]
2023-11-09 10:52:50 }

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
  Platform: linux
  Arch: arm64
  Version: SMP Fri Aug 18 21:57:12 PDT 2023
Binaries:
  Node: 20.8.1
  npm: 10.1.1
  Yarn: 1.22.19
  pnpm: N/A
Relevant Packages:
  next: 14.0.0
  react: 18.2.0
  react—don: 18.2.0
  typescript: 5.2.2
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

App Router, Operating System (Windows, MacOS, Linux)

Additional context

If you look in the discussion forum, you can see that it works in version 13.4.19.
You can also see that people have identified the specific problem that needs to be resolved.
The line:

return `commonjs ${localRes.replace(/.*?next[/\\]dist/, "next/dist")}`

Has to be replaced with:

return `commonjs ${localRes.replace(/.*?next[/\\]dist/, "next/dist").replace(/\\/g, "/")}`

In the file "\node_modules\next\dist\build\handle-externals.js", to generate the correct paths.
@alexop1000 alexop1000 added the bug Issue was opened via the bug report template. label Nov 9, 2023
@shahkeyur
Copy link

+1, having same issue while deploying to app engine.

@DeanJGrey
Copy link

Same issue when using OpenNext to deploy to AWS.
Rolling back to 13.4.19 has resolved this issue for the time being.

@mizhousoft
Copy link

+1, having same issue while deploying to app engine.

1 similar comment
@Ryan2018-js
Copy link

+1, having same issue while deploying to app engine.

@willersonsp
Copy link

+1 here deploying on bohr/aws, using node_modules line with replace works nicely.

@keyur2582 keyur2582 mentioned this issue Nov 13, 2023
Closed
@sonnydg sonnydg mentioned this issue Nov 14, 2023
Closed
@Enngage
Copy link

Enngage commented Nov 21, 2023 •
edited
Loading

+1, please fix this so we can safely upgrade to next 14

1 similar comment
@Shdoogii
Copy link

+1, please fix this so we can safely upgrade to next 14

@kazio0

This comment has been minimized.

Sign in to view
@vincent-thomas
Copy link

+1 Pleeeease fix this, its so anoying

@jayanty33
Copy link

return commonjs ${localRes.replace(/.*?next[/\\]dist/, "next/dist")}

Has to be replaced with:

return commonjs ${localRes.replace(/.*?next[/\\]dist/, "next/dist").replace(/\\/g, "/")} this is working on next14.0.3

@marcellintacite marcellintacite mentioned this issue Dec 16, 2023
Closed
@deathg0d deathg0d mentioned this issue Dec 28, 2023
Closed
@timneutkens timneutkens mentioned this issue Jan 2, 2024
Merged
timneutkens added a commit that referenced this issue Jan 2, 2024
@timneutkens @keyur2582
Fix path issues on linux machines when build created on windows (#60116)
5f6cd8f 
Copy of #58398 with `normalizePathSep` applied. Unfortunately the branch
wasn't editable, I'm guessing because it was opened on an organization
instead of an individual.

Fixes #58244
Closes #58398

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-1943

---------

Co-authored-by: keyur2582 <52085601+keyur2582@users.noreply.github.com>
agustints pushed a commit to agustints/next.js that referenced this issue Jan 6, 2024
@timneutkens @keyur2582 @agustints
Fix path issues on linux machines when build created on windows (verc…
7c947d8 
…el#60116)

Copy of vercel#58398 with `normalizePathSep` applied. Unfortunately the branch
wasn't editable, I'm guessing because it was opened on an organization
instead of an individual.

Fixes vercel#58244
Closes vercel#58398

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-1943

---------

Co-authored-by: keyur2582 <52085601+keyur2582@users.noreply.github.com>
@seyhak
Copy link

seyhak commented Jan 7, 2024

issue still occurs

@github-actions GitHub Actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template. locked
Projects
None yet
Milestone
No milestone
13 participants
@mizhousoft @Shdoogii @Enngage @kazio0 @willersonsp @seyhak @DeanJGrey @Ryan2018-js @shahkeyur @alexop1000 @vincent-thomas @jayanty33 and others