adding hostname argument to CLI #1017

jessehattabaugh · 2017-02-06T18:57:03Z

No description provided.

nkzawa · 2017-02-07T02:22:35Z

bin/next-start

@@ -10,11 +10,13 @@ process.env.NODE_ENV = process.env.NODE_ENV || 'production'
 const argv = parseArgs(process.argv.slice(2), {
  alias: {
    h: 'help',
+    hn: 'hostname',


I think -H or -a (address) is better.

We use -H for micro lets use that to keep it consistent.

jessehattabaugh · 2017-02-07T02:34:02Z

-H is used by other tools I've seen

…

On Mon, Feb 6, 2017, 6:22 PM Naoyuki Kanezawa ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In bin/next-start <#1017 (review)>: > @@ -10,11 +10,13 @@ process.env.NODE_ENV = process.env.NODE_ENV || 'production' const argv = parseArgs(process.argv.slice(2), { alias: { h: 'help', + hn: 'hostname', I think -H or -a (address) is better. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1017 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABGR_HL25-jk5XkMkacpZjikdObR1eSks5rZ9VvgaJpZM4L4lJA> .

jessehattabaugh

I made the change to the arg alias as requested. It's now -H instead of -hn

nkzawa · 2017-02-08T00:26:10Z

bin/next-start

    p: 'port'
  },
  boolean: ['h'],
  default: {
-    p: 3000
+    p: 3000,
+    hostname: 'localhost'


I think it'll be safe to not have default value for hostname.

Yeah! I think with this it only listen on localhost not with others like 127.0.0.1

If there's no default then the second argument to listen() will be undefined. I'm not sure what that would do.

taken from https://nodejs.org/api/http.html#http_server_listen_port_hostname_backlog_callback:

If the hostname is omitted, the server will accept connections on any IPv6 address (::) when IPv6 is available, or any IPv4 address (0.0.0.0) otherwise.

@nkzawa is right 😄

"omitted", but what if undefined or null is passed? There's one way to find out I guess

@jessehattabaugh great though actually. Only now I'm remembering that when you pass -H without a hostname it will actually turn into true

jessehattabaugh · 2017-02-08T21:03:56Z

server/index.js

    await this.prepare()
    this.http = http.createServer(this.getRequestHandler())
    await new Promise((resolve, reject) => {
      // This code catches EADDRINUSE error if the port is already in use
      this.http.on('error', reject)
      this.http.on('listening', () => resolve())
-      this.http.listen(port)
+      if (hostname) this.http.listen(port, hostname)


I decided to be careful and only call listen() with a hostname arg if something truthy is passed to start

please make this a if/else with { and }, standardjs should have caught this 🤔

taken from my other comment:

@jessehattabaugh great though actually. Only now I'm remembering that when you pass -H without a hostname it will actually turn into true

If you check for hostname it will evaluate to true when passing -H 😅 It think it's best to check if it is a valid number or something like that 🤔

cc @nkzawa

jessehattabaugh · 2017-02-08T23:16:42Z

server/index.js

    await this.prepare()
    this.http = http.createServer(this.getRequestHandler())
    await new Promise((resolve, reject) => {
      // This code catches EADDRINUSE error if the port is already in use
      this.http.on('error', reject)
      this.http.on('listening', () => resolve())
-      this.http.listen(port)
+      if (hostname && typeof hostname !== 'boolean') {


@timneutkens good catch about empty -H evaluating true

I think we can use the string option of minimist.

True, merging this in, will fix after merging.

timneutkens

I'll fix @nkzawa's note on minimist's string option.

schoenwaldnils · 2018-12-17T11:54:46Z

Would it make sense to have those things (port, hostname) editable in the next.config.js?

timneutkens · 2018-12-17T11:58:37Z

No, as they're runtime values and are only applicable when using next / next start. See #5846

schoenwaldnils · 2018-12-17T13:26:31Z

Hm, ok, that sounds plausible.
What about the CLI option to point at another config file in which all CLI options could be defined?
Like next dev --config config.js?

timneutkens · 2018-12-17T14:19:24Z

You could create a shell script with predefined options.

adding hostname argument to CLI

4da2c28

jessehattabaugh mentioned this pull request Feb 6, 2017

Add --hostname argument to cli #1010

Closed

nkzawa reviewed Feb 7, 2017

View reviewed changes

using -H instead of -hn

f22f299

jessehattabaugh commented Feb 7, 2017

View reviewed changes

nkzawa reviewed Feb 8, 2017

View reviewed changes

removing hostname default

4390012

jessehattabaugh commented Feb 8, 2017

View reviewed changes

checking that hostname has a truthy value that's not a boolean

181905d

jessehattabaugh commented Feb 8, 2017

View reviewed changes

jessehattabaugh added 2 commits February 8, 2017 23:26

making the log message match the hostname

1dc9125

oops

3866d3a

timneutkens approved these changes Feb 12, 2017

View reviewed changes

timneutkens merged commit c4a22ab into vercel:master Feb 12, 2017

timneutkens mentioned this pull request Feb 12, 2017

Use minimist string option for hostname #1090

Merged

sco mentioned this pull request Jul 8, 2017

next-dev CLI should take hostname argument #2500

Closed

1 task

lock bot locked as resolved and limited conversation to collaborators Dec 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding hostname argument to CLI #1017

adding hostname argument to CLI #1017

jessehattabaugh commented Feb 6, 2017

nkzawa Feb 7, 2017

timneutkens Feb 7, 2017

jessehattabaugh commented Feb 7, 2017 via email

jessehattabaugh left a comment

nkzawa Feb 8, 2017

arunoda Feb 8, 2017 •

edited

Loading

jessehattabaugh Feb 8, 2017

timneutkens Feb 8, 2017 •

edited

Loading

jessehattabaugh Feb 8, 2017 •

edited

Loading

timneutkens Feb 8, 2017

jessehattabaugh Feb 8, 2017 •

edited

Loading

timneutkens Feb 8, 2017

timneutkens Feb 8, 2017

jessehattabaugh Feb 8, 2017

nkzawa Feb 9, 2017

timneutkens Feb 12, 2017

timneutkens left a comment

schoenwaldnils commented Dec 17, 2018

timneutkens commented Dec 17, 2018 •

edited

Loading

schoenwaldnils commented Dec 17, 2018

timneutkens commented Dec 17, 2018

adding hostname argument to CLI #1017

adding hostname argument to CLI #1017

Conversation

jessehattabaugh commented Feb 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessehattabaugh commented Feb 7, 2017 via email

jessehattabaugh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arunoda Feb 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timneutkens Feb 8, 2017 • edited Loading

Choose a reason for hiding this comment

jessehattabaugh Feb 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessehattabaugh Feb 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timneutkens left a comment

Choose a reason for hiding this comment

schoenwaldnils commented Dec 17, 2018

timneutkens commented Dec 17, 2018 • edited Loading

schoenwaldnils commented Dec 17, 2018

timneutkens commented Dec 17, 2018

arunoda Feb 8, 2017 •

edited

Loading

timneutkens Feb 8, 2017 •

edited

Loading

jessehattabaugh Feb 8, 2017 •

edited

Loading

jessehattabaugh Feb 8, 2017 •

edited

Loading

timneutkens commented Dec 17, 2018 •

edited

Loading