Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove native-url #10176

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Remove native-url #10176

merged 2 commits into from
Jan 20, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 20, 2020

native-url is currently broken, let's disable it for now.

x-ref: #10108
x-ref: #10103
x-ref: #10102

@Timer Timer added this to the 9.2.1 milestone Jan 20, 2020
ijjk
ijjk reviewed Jan 20, 2020
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to revert the size-limit test changes also

Screen Shot 2020-01-20 at 13 31 53

@ijjk
Copy link
Member

ijjk commented Jan 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/native-url Change
buildDuration 12.5s 12.9s ⚠️ +409ms
nodeModulesSize 48.9 MB 48.8 MB -149 kB
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary Timer/next.js remove/native-url Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..fffc.js gzip 13.7 kB 16.3 kB ⚠️ +2.54 kB
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 70 kB ⚠️ +2.54 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/native-url Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..dule.js gzip N/A 15.1 kB N/A
Overall change 62.1 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/native-url Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages Overall increase ⚠️
zeit/next.js canary Timer/next.js remove/native-url Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ⚠️ +1 B
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ⚠️ +1 B
Client Pages Modern
zeit/next.js canary Timer/next.js remove/native-url Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js remove/native-url Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB -1 B
withRouter.html gzip 1.01 kB 1.02 kB ⚠️ +1 B
Overall change 3.06 kB 3.06 kB ✓

Diffs

Diff for link.js 
@@ -441,7 +441,7 @@
 
       var _map = _interopRequireDefault(__webpack_require__('LX0d'))
 
-      var _url = __webpack_require__('QmWs')
+      var _url = __webpack_require__('CxY0')
 
       var _react = _interopRequireWildcard(__webpack_require__('q1tI'))
Diff for link.module.js 
@@ -316,7 +316,7 @@
 
       var _map = _interopRequireDefault(__webpack_require__('LX0d'))
 
-      var _url = __webpack_require__('QmWs')
+      var _url = __webpack_require__('CxY0')
 
       var _react = _interopRequireWildcard(__webpack_require__('q1tI'))
Diff for de003c3a9d30..91f4552b5.js

Diff too large to display

Diff for de003c3a9d30..48.module.js

Diff too large to display

Diff for index.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -151,13 +151,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d13a4f99d1b35e11fb4.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -156,13 +156,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d13a4f99d1b35e11fb4.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -151,13 +151,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d13a4f99d1b35e11fb4.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/native-url Change
buildDuration 13.3s 13.8s ⚠️ +426ms
nodeModulesSize 48.9 MB 48.8 MB -149 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/native-url Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..fffc.js gzip 13.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..c512.js gzip N/A 16.3 kB N/A
Overall change 67.5 kB 70 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/native-url Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..dule.js gzip N/A 15.1 kB N/A
Overall change 62.1 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/native-url Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages Overall increase ⚠️
zeit/next.js canary Timer/next.js remove/native-url Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ⚠️ +1 B
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ⚠️ +1 B
Client Pages Modern
zeit/next.js canary Timer/next.js remove/native-url Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary Timer/next.js remove/native-url Change
_error.js gzip 70.9 kB 70.9 kB -1 B
hooks.html gzip 1.05 kB 1.05 kB ✓
index.js gzip 71.3 kB 71.3 kB -1 B
link.js gzip 80.6 kB 80.6 kB ⚠️ +1 B
routerDirect.js gzip 78.2 kB 78.2 kB ✓
withRouter.js gzip 78.3 kB 78.3 kB ✓
Overall change 380 kB 380 kB -1 B

Commit: de92cf8

@Timer Timer requested a review from ijjk January 20, 2020 19:42
@ijjk
Copy link
Member

ijjk commented Jan 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/native-url Change
buildDuration 13.7s 14s ⚠️ +303ms
nodeModulesSize 48.9 MB 48.8 MB -149 kB
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary Timer/next.js remove/native-url Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..fffc.js gzip 13.7 kB 16.3 kB ⚠️ +2.54 kB
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 70 kB ⚠️ +2.54 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/native-url Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..dule.js gzip N/A 15.1 kB N/A
Overall change 62.1 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/native-url Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages Overall increase ⚠️
zeit/next.js canary Timer/next.js remove/native-url Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ⚠️ +1 B
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ⚠️ +1 B
Client Pages Modern
zeit/next.js canary Timer/next.js remove/native-url Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js remove/native-url Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB -1 B
withRouter.html gzip 1.01 kB 1.02 kB ⚠️ +1 B
Overall change 3.06 kB 3.06 kB ✓

Diffs

Diff for link.js 
@@ -441,7 +441,7 @@
 
       var _map = _interopRequireDefault(__webpack_require__('LX0d'))
 
-      var _url = __webpack_require__('QmWs')
+      var _url = __webpack_require__('CxY0')
 
       var _react = _interopRequireWildcard(__webpack_require__('q1tI'))
Diff for link.module.js 
@@ -316,7 +316,7 @@
 
       var _map = _interopRequireDefault(__webpack_require__('LX0d'))
 
-      var _url = __webpack_require__('QmWs')
+      var _url = __webpack_require__('CxY0')
 
       var _react = _interopRequireWildcard(__webpack_require__('q1tI'))
Diff for de003c3a9d30..91f4552b5.js

Diff too large to display

Diff for de003c3a9d30..48.module.js

Diff too large to display

Diff for index.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -151,13 +151,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d13a4f99d1b35e11fb4.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -156,13 +156,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d13a4f99d1b35e11fb4.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -39,7 +39,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -151,13 +151,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.329e15c764091f4552b5.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.9d13a4f99d1b35e11fb4.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.a0d7d22cc5017428eb48.module.js"
+      src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.494ccc4c3d846ffaa4a8.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js remove/native-url Change
buildDuration 14.1s 14.5s ⚠️ +362ms
nodeModulesSize 48.9 MB 48.8 MB -149 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js remove/native-url Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..fffc.js gzip 13.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..c512.js gzip N/A 16.3 kB N/A
Overall change 67.5 kB 70 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js remove/native-url Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
de003c3a9d30..dule.js gzip N/A 15.1 kB N/A
Overall change 62.1 kB 64.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js remove/native-url Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages Overall increase ⚠️
zeit/next.js canary Timer/next.js remove/native-url Change
_app.js gzip 1.34 kB 1.34 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ⚠️ +1 B
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ⚠️ +1 B
Client Pages Modern
zeit/next.js canary Timer/next.js remove/native-url Change
_app.module.js gzip 769 B 769 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.42 kB 7.42 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js remove/native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary Timer/next.js remove/native-url Change
_error.js gzip 70.9 kB 70.9 kB -1 B
hooks.html gzip 1.05 kB 1.05 kB ✓
index.js gzip 71.3 kB 71.3 kB -1 B
link.js gzip 80.6 kB 80.6 kB ⚠️ +1 B
routerDirect.js gzip 78.2 kB 78.2 kB ✓
withRouter.js gzip 78.3 kB 78.3 kB ✓
Overall change 380 kB 380 kB -1 B

Commit: e0686ac

@Timer Timer merged commit 2e668e6 into vercel:canary Jan 20, 2020
@Timer Timer deleted the remove/native-url branch January 20, 2020 19:47
@Timer
Copy link
Member Author

Timer commented Jan 21, 2020

Another one: #10186

@timneutkens timneutkens mentioned this pull request Feb 3, 2020
Closed
This was referenced Feb 18, 2020
Closed
Open
@ijjk ijjk mentioned this pull request Feb 20, 2020
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Timer @ijjk