Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with-emotion examples #13005

Merged
merged 1 commit into from
May 18, 2020
Merged

Fix with-emotion examples #13005

merged 1 commit into from
May 18, 2020

Conversation

lboecker
Copy link
Contributor

This fixes the issues I describe in #12384

(Copy and paste for convenience)

I've played around with the with-emotion example and ran into a couple of issues with next/head:

  1. The default <meta charSet="..." /> is placed after the inlined styles (possibly after the first 1024 bytes).
  2. I tried to be clever and put my own <meta charSet="..." /> above the style tag in _document.js which somehow made me end up with 2 <meta charSet="..." /> elements.
  3. I would have expected the global stylesheets to be placed at the beginning of <head>, allowing me to override them.

@lboecker lboecker requested review from lfades and Timer as code owners May 17, 2020 12:47
@lboecker lboecker mentioned this pull request May 17, 2020
Closed
@ijjk
Copy link
Member

ijjk commented May 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
buildDuration 12.7s 13.2s ⚠️ +443ms
nodeModulesSize 58.5 MB 58.5 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.176 2.155 -0.02
/ avg req/sec 1149.16 1160.36 ⚠️ +11.2
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.407 1.402 -0.01
/error-in-render avg req/sec 1777.26 1783.11 ⚠️ +5.85
Client Bundles (main, webpack, commons)
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
main-HASH.js gzip 6.67 kB 6.67 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
buildDuration 13.6s 13.7s ⚠️ +119ms
nodeModulesSize 58.5 MB 58.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
main-HASH.js gzip 6.67 kB 6.67 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
main-HASH.module.js gzip 5.71 kB 5.71 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary lboecker/next.js fix-emotion-examples Change
_error.js 850 kB 850 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 880 kB 880 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@Timer Timer added the examples Issue was opened via the examples template. label May 18, 2020
@Timer Timer added this to the 9.4.2 milestone May 18, 2020
@Timer Timer merged commit 36ddada into vercel:canary May 18, 2020
@lboecker lboecker deleted the fix-emotion-examples branch May 18, 2020 17:23
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@lboecker @chibicode
Fix with-emotion examples (vercel#13005)
8582c07
@chrisalbert chrisalbert mentioned this pull request Jun 26, 2020
Closed
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@lboecker @rokinsky
Fix with-emotion examples (vercel#13005)
d09d70e
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Vadorequest Vadorequest Vadorequest left review comments

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
9.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@lboecker @ijjk @Timer @Vadorequest