-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for URL objects in Link and Router #1345
Merged
Merged
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
87d8a31
Add support for URL objects in Link and Router
sergiodxa 1334cf8
Fix typo in comment
sergiodxa 2332339
Fix possible bug if the `href` prop is `null`
sergiodxa 846f307
Document the usage of URL objects in Link and Router
sergiodxa a23ddc6
Merge branch 'master' into support-url-objects
sergiodxa 906ab66
Update readme.md
sergiodxa 32f371d
Parse URL to get the host & hostname in `isLocal`
sergiodxa 9a768e3
Merge remote-tracking branch 'zeit/master' into support-url-objects
sergiodxa 3df3f9d
Format `as` parameter from object to string if required
sergiodxa bba0934
Format `href` and `as` inside the construct and componentWillReceiveP…
sergiodxa 4b54650
Use `JSON.stringify` to compare objects
sergiodxa 3b7785c
Merge remote-tracking branch 'zeit/master' into support-url-objects
sergiodxa 5612fbe
Add usage example
sergiodxa 0d01f5c
chore(package): update chromedriver to version 2.28.0 (#1386)
greenkeeper[bot] bd34cc7
Merge branch 'support-url-objects' of https://github.com/sergiodxa/ne…
arunoda 58a4bf3
Refactor the codebase a bit.
arunoda 7186145
Change the example name.
arunoda b18b1db
Add a few test cases.
arunoda acf7620
Add the example to the README.
arunoda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
typeof null === 'object'
results intrue
andrequire('url').format(null)
throws an exception, should we doif(href && typeof href === 'object')
?