Move all NPM modules into a single chunk in dev mode. #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will isolate all the NPM modules into a single chunk. That chunk won't touch by webpack unless, there's a new NPM module. That gives us much better re-build performance.
|
Did this include every module inside node_modules? What about non required modules? If I have ESLint inside my node_modules this include that too? |
|
@sergiodxa ah not all. |
|
@arunoda ahh ok, I just wanted to understand that |
|
@rauchg Why was it reverted? Will it be improved somehow? |
|
@frol we did another PR with the same. This one had a bug. |
|
It would have been much helpful if you refer to the issues/PRs. It seems that that was #1512. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #941
This will isolate all the NPM modules into a single chunk.
That chunk won't touch by webpack unless, there's a new NPM module.
That gives us much better re-build performance.
This does the same think as what #941 does. But now this is automatically works for all NPM modules.