Improvements - Font optimizations #16031

prateekbh · 2020-08-10T04:34:28Z

Adds webpack 5 compatibility.
Minifies downloaded CSS at build time to save impact on response times.
Disabled this optimization for dev time as it currently crashes the dev server.

ijjk · 2020-08-10T04:44:48Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
buildDuration	12.7s	12.7s	⚠️ +39ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +2.74 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	azukaru/next.js font-improvements	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.272	2.188	-0.08
/ avg req/sec	1100.47	1142.48	+42.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.286	1.266	-0.02
/error-in-render avg req/sec	1944.68	1974.37	+29.69

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-008324e..83e7.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c621fe2..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js font-improvements	Change
index.html gzip	948 B	948 B	✓
link.html gzip	954 B	954 B	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
buildDuration	14.1s	14.2s	⚠️ +43ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +2.74 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-008324e..83e7.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c621fe2..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_error.js	1.03 MB	1.03 MB	-21 B
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	-21 B
link.js	1.07 MB	1.07 MB	-21 B
routerDirect.js	1.06 MB	1.06 MB	-21 B
withRouter.js	1.06 MB	1.06 MB	-21 B
Overall change	5.26 MB	5.26 MB	-105 B

Commit: bc8f9d9

ijjk · 2020-08-10T04:45:04Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
buildDuration	13.4s	13.5s	⚠️ +68ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +2.74 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.458	2.485	⚠️ +0.03
/ avg req/sec	1016.99	1006.04	⚠️ -10.95
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.403	1.482	⚠️ +0.08
/error-in-render avg req/sec	1781.34	1687.29	⚠️ -94.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-008324e..83e7.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c621fe2..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js font-improvements	Change
index.html gzip	948 B	948 B	✓
link.html gzip	954 B	954 B	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
buildDuration	14.6s	14.7s	⚠️ +94ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +2.74 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-008324e..83e7.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c621fe2..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_error.js	1.03 MB	1.03 MB	-21 B
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	-21 B
link.js	1.07 MB	1.07 MB	-21 B
routerDirect.js	1.06 MB	1.06 MB	-21 B
withRouter.js	1.06 MB	1.06 MB	-21 B
Overall change	5.26 MB	5.26 MB	-105 B

Commit: d5a6c8e

…into font-improvements

ijjk · 2020-08-10T05:54:50Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
buildDuration	10.4s	10.3s	-98ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +2.77 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	azukaru/next.js font-improvements	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.89	1.897	⚠️ +0.01
/ avg req/sec	1322.82	1318.02	⚠️ -4.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.205	1.195	-0.01
/error-in-render avg req/sec	2074.38	2091.3	+16.92

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-008324e..83e7.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c621fe2..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js font-improvements	Change
index.html gzip	948 B	948 B	✓
link.html gzip	954 B	954 B	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
buildDuration	11.6s	11.4s	-278ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +2.77 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-008324e..83e7.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c621fe2..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_error.js	1.03 MB	1.03 MB	-21 B
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	-21 B
link.js	1.07 MB	1.07 MB	-21 B
routerDirect.js	1.06 MB	1.06 MB	-21 B
withRouter.js	1.06 MB	1.06 MB	-21 B
Overall change	5.26 MB	5.26 MB	-105 B

Commit: af93ab6

packages/next/build/webpack/plugins/font-stylesheet-gathering-plugin.ts

…plugin.ts Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

ijjk · 2020-08-10T07:56:50Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
buildDuration	12.6s	12.8s	⚠️ +215ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +2.65 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.357	2.396	⚠️ +0.04
/ avg req/sec	1060.49	1043.45	⚠️ -17.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.419	1.417	0
/error-in-render avg req/sec	1761.63	1764.08	+2.45

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-008324e..83e7.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c621fe2..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js font-improvements	Change
index.html gzip	948 B	948 B	✓
link.html gzip	954 B	954 B	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js font-improvements	Change
buildDuration	14.4s	14s	-345ms
nodeModulesSize	65.7 MB	65.7 MB	⚠️ +2.65 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..ec1a.js gzip	9.99 kB	9.99 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-008324e..83e7.js gzip	6.74 kB	6.74 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	56.6 kB	56.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
677f882d2ed8..dule.js gzip	5.89 kB	5.89 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-c621fe2..dule.js gzip	5.81 kB	5.81 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js font-improvements	Change
polyfills-75..1629.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	azukaru/next.js font-improvements	Change
_error.js	1.03 MB	1.03 MB	-21 B
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	-21 B
link.js	1.07 MB	1.07 MB	-21 B
routerDirect.js	1.06 MB	1.06 MB	-21 B
withRouter.js	1.06 MB	1.06 MB	-21 B
Overall change	5.26 MB	5.26 MB	-105 B

Commit: 3401ca2

Timer

LGTM, had offline discussion about tests. Future PR will include:

It not being enabled in dev (changed in this PR)
Some sort of CSS snapshot for the inlined style

c0b41 · 2020-08-10T20:36:17Z

@prateekbh this feature still broken see #14746 (comment) codesandbox

prateekbh · 2020-08-10T20:46:10Z

@c0b41 I see that the sandbox is still pointing to 9.5.1 you'll need to update to latest canary.16

prateekbh · 2020-08-10T20:49:16Z

here's a working link with nextjs on canary: https://codesandbox.io/s/infallible-wind-f6cww

c0b41 · 2020-08-10T20:50:58Z

@prateekbh ohh you are right, latest canary fixed sorry

prateekbh · 2020-08-10T20:53:31Z

no worries! thanks for keeping an eye out on this 👍🏻

c0b41 · 2020-08-10T21:46:42Z

@prateekbh looks like this feature broke amp support, you can test out locally codesandbox

first amp-validator throwing error this lines endsWith, startsWith L47 L75
after this lines fix, also throwing warning

/bar  error  The mandatory attribute 'href' is missing in tag 'link rel=stylesheet for fonts'.  https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/#custom-fonts

prateekbh · 2020-08-11T01:06:06Z

Yeah, I don't think this is ready to work with AMP at all.
Moreover amp has it's own font optimization on its CDN. So yes I wouldn't use this together with AMP

kevva · 2020-08-11T08:17:19Z

@prateekbh, ideally, it would detect AMP pages then and skip optimizations for them. There could be some pages that are and some that aren't AMP and want the font optimization on the non-AMP ones which isn't possible at the moment.

prateekbh · 2020-08-11T16:17:39Z

@kevva totally agreed. I'll add that case and a test for it

prateekbh added 2 commits August 9, 2020 21:26

webpack 5 compatibility and minification at build time

8113795

disable optimizeFonts for dev

bc8f9d9

prateekbh requested review from ijjk, lfades, Timer and timneutkens as code owners August 10, 2020 04:34

ijjk added the type: next label Aug 10, 2020

Merge branch 'canary' into font-improvements

d5a6c8e

prateekbh added 2 commits August 9, 2020 22:46

disabling font optimizations for dev server

f42905d

Merge branch 'font-improvements' of https://github.com/azukaru/next.js …

af93ab6

…into font-improvements

timneutkens reviewed Aug 10, 2020

View reviewed changes

packages/next/build/webpack/plugins/font-stylesheet-gathering-plugin.ts Outdated Show resolved Hide resolved

timneutkens reviewed Aug 10, 2020

View reviewed changes

packages/next/build/webpack/plugins/font-stylesheet-gathering-plugin.ts Show resolved Hide resolved

Update packages/next/build/webpack/plugins/font-stylesheet-gathering-…

3401ca2

…plugin.ts Co-authored-by: Tim Neutkens <tim@timneutkens.nl>

timneutkens approved these changes Aug 10, 2020

View reviewed changes

Merge branch 'canary' into font-improvements

4e90a22

Timer approved these changes Aug 10, 2020

View reviewed changes

Timer merged commit 2ddfd84 into vercel:canary Aug 10, 2020

Timer deleted the font-improvements branch August 10, 2020 18:06

joe-bell mentioned this pull request Aug 11, 2020

[Font Optimization] Asynchronous non-critical font styles #16065

Closed

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvements - Font optimizations #16031

Improvements - Font optimizations #16031

prateekbh commented Aug 10, 2020

ijjk commented Aug 10, 2020

ijjk commented Aug 10, 2020

ijjk commented Aug 10, 2020

ijjk commented Aug 10, 2020

Timer left a comment

c0b41 commented Aug 10, 2020

prateekbh commented Aug 10, 2020

prateekbh commented Aug 10, 2020

c0b41 commented Aug 10, 2020

prateekbh commented Aug 10, 2020

c0b41 commented Aug 10, 2020

prateekbh commented Aug 11, 2020

kevva commented Aug 11, 2020

prateekbh commented Aug 11, 2020

Improvements - Font optimizations #16031

Improvements - Font optimizations #16031

Conversation

prateekbh commented Aug 10, 2020

ijjk commented Aug 10, 2020

Stats from current PR

ijjk commented Aug 10, 2020

Stats from current PR

ijjk commented Aug 10, 2020

Stats from current PR

ijjk commented Aug 10, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

c0b41 commented Aug 10, 2020

prateekbh commented Aug 10, 2020

prateekbh commented Aug 10, 2020

c0b41 commented Aug 10, 2020

prateekbh commented Aug 10, 2020

c0b41 commented Aug 10, 2020

prateekbh commented Aug 11, 2020

kevva commented Aug 11, 2020

prateekbh commented Aug 11, 2020