Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing dependency caniuse-lite #16091

Merged
merged 2 commits into from
Aug 14, 2020
Merged

fix: add missing dependency caniuse-lite #16091

merged 2 commits into from
Aug 14, 2020

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Aug 11, 2020

What's the problem this PR addresses?

#16048 stopped bundling caniuse-lite but didn't declare it as a dependency

https://github.com/yarnpkg/berry/runs/972037981?check_suite_focus=true#step:5:75

How did you fix it?

Add caniuse-lite as a dependency

cc @Timer

As mentioned in #14157 (comment) I looked into adding a PnP e2e test but the use of the gist protocol stopped me from getting it to work since v2 doesn't support that yet. Would it be possible to change this to one of the supported protocols (https://yarnpkg.com/features/protocols)?

next.js/packages/next/package.json

Line 208 in 6366727

"terser-webpack-plugin": "gist:1b826e8b64f73158df99990d1b4624fa",

@ijjk
Copy link
Member

ijjk commented Aug 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
buildDuration 10.9s 11.1s ⚠️ +168ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +189 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.967 2.064 ⚠️ +0.1
/ avg req/sec 1270.66 1211.41 ⚠️ -59.25
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.088 1.073 -0.02
/error-in-render avg req/sec 2298.59 2330.66 +32.07
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
buildDuration 12.7s 12.6s -73ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +189 B
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: cae1c9a

@ijjk
Copy link
Member

ijjk commented Aug 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
buildDuration 13.8s 13.9s ⚠️ +26ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +189 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.601 2.644 ⚠️ +0.04
/ avg req/sec 961.07 945.5 ⚠️ -15.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.594 1.582 -0.01
/error-in-render avg req/sec 1568.03 1580.63 +12.6
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
buildDuration 16s 15.7s -335ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +189 B
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: cae1c9a

@timneutkens
Copy link
Member

As mentioned in #14157 (comment) I looked into adding a PnP e2e test but the use of the gist protocol stopped me from getting it to work since v2 doesn't support that yet. Would it be possible to change this to one of the supported protocols (yarnpkg.com/features/protocols)?

We can get rid of the gist package soon as latest terser was published, just has to be upgraded.

@ijjk
Copy link
Member

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
buildDuration 13s 13s ⚠️ +83ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +189 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.42 2.336 -0.08
/ avg req/sec 1032.98 1070.15 +37.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.398 1.485 ⚠️ +0.09
/error-in-render avg req/sec 1787.88 1683.55 ⚠️ -104.33
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
index.html gzip 946 B 946 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
buildDuration 15.3s 15.2s -181ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +189 B
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/caniuse-lite Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: 4c62a84

@kodiakhq kodiakhq bot merged commit db40a39 into vercel:canary Aug 14, 2020
@merceyz merceyz deleted the merceyz/caniuse-lite branch August 14, 2020 14:03
@TrySound
Copy link
Contributor

What's the point of this change? Does any module in next.js use it directly? I don't see it here
https://github.com/vercel/next.js/search?q=caniuse-lite&unscoped_q=caniuse-lite

@TrySound
Copy link
Contributor

Ah, sorry. I see it's in bundled babel-preset-env.

@timneutkens timneutkens mentioned this pull request Aug 16, 2020
Closed
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@merceyz
fix: add missing dependency caniuse-lite (vercel#16091)
9867373 
**What's the problem this PR addresses?**

vercel#16048 stopped bundling `caniuse-lite` but didn't declare it as a dependency

https://github.com/yarnpkg/berry/runs/972037981?check_suite_focus=true#step:5:75

**How did you fix it?**

Add `caniuse-lite` as a dependency

---
cc @Timer 

As mentioned in vercel#14157 (comment) I looked into adding a PnP e2e test but the use of the `gist` protocol stopped me from getting it to work since v2 doesn't support that yet. Would it be possible to change this to one of the supported protocols (https://yarnpkg.com/features/protocols)?
https://github.com/vercel/next.js/blob/636672755004c756eefcddb5d4ccabbc1855e75a/packages/next/package.json#L208
@simnalamburt simnalamburt mentioned this pull request Aug 25, 2020
Closed
@merceyz merceyz mentioned this pull request May 2, 2021
Merged
1 task
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merceyz @ijjk @timneutkens @TrySound