Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser back issue of redirects from getServerSideProps / getStaticProps #17741

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Fix browser back issue of redirects from getServerSideProps / getStaticProps #17741

merged 3 commits into from
Oct 27, 2020

Conversation

TasukuUno
Copy link
Contributor

@TasukuUno TasukuUno commented Oct 9, 2020 •
edited
Loading

Changed the router's behavior of handling client-side redirect to fix browser back issue.
My intention is written in code comments below.

Fixed #17738

@ijjk ijjk added the type: next label Oct 9, 2020
@ijjk
Copy link
Member

ijjk commented Oct 9, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
buildDuration 13.4s 13.2s -226ms
nodeModulesSize 63.4 MB 63.4 MB -83 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.517 2.577 ⚠️ +0.06
/ avg req/sec 993.29 970.09 ⚠️ -23.2
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.57 1.571 0
/error-in-render avg req/sec 1592.07 1591.52 ⚠️ -0.55
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
677f882d2ed8..9b19.js gzip 11.1 kB 11.1 kB ⚠️ +2 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-ef5fcfe..d66c.js gzip 7.24 kB 7.24 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58 kB 58 kB ⚠️ +2 B
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1c7f28c..dule.js gzip 6.29 kB 6.29 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
index.html gzip 1 kB 1 kB -3 B
link.html gzip 1.01 kB 1.01 kB -1 B
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3 kB -4 B

Diffs

Diff for 677f882d2ed8..4eeebf399.js 
@@ -1521,7 +1521,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                             return _context.abrupt(
                               "return",
                               this.change(
-                                "replaceState",
+                                method,
                                 destination,
                                 destination,
                                 options
Diff for 677f882d2ed8..20.module.js 
@@ -1223,12 +1223,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                 this._resolveHref(parsedHref, pages);
 
                 if (pages.includes(parsedHref.pathname)) {
-                  return this.change(
-                    "replaceState",
-                    destination,
-                    destination,
-                    options
-                  );
+                  return this.change(method, destination, destination, options);
                 }
               }
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d950dcaaa011f2b8e120.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4dd38052fc5492a228d4.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.5472d08d2594eeebf399.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.04e86b8d8a15425233c8.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d950dcaaa011f2b8e120.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4dd38052fc5492a228d4.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d950dcaaa011f2b8e120.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4dd38052fc5492a228d4.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -126,13 +126,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.5472d08d2594eeebf399.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.04e86b8d8a15425233c8.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d950dcaaa011f2b8e120.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4dd38052fc5492a228d4.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d950dcaaa011f2b8e120.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4dd38052fc5492a228d4.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.5472d08d2594eeebf399.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.04e86b8d8a15425233c8.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d950dcaaa011f2b8e120.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4dd38052fc5492a228d4.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
buildDuration 15s 15.1s ⚠️ +70ms
nodeModulesSize 63.4 MB 63.4 MB -83 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
677f882d2ed8..9b19.js gzip 11.1 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-ef5fcfe..d66c.js gzip 7.24 kB 7.24 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..ede7.js gzip N/A 11.1 kB N/A
Overall change 58 kB 58 kB ⚠️ +2 B
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
677f882d2ed8..dule.js gzip 6.9 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1c7f28c..dule.js gzip 6.29 kB 6.29 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 6.9 kB N/A
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.73 kB 7.73 kB ✓
Client Pages Modern
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-92d3016..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_error.js 1.05 MB 1.05 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.05 MB 1.05 MB ✓
link.js 1.1 MB 1.1 MB -8 B
routerDirect.js 1.09 MB 1.09 MB -8 B
withRouter.js 1.09 MB 1.09 MB -8 B
Overall change 5.41 MB 5.41 MB -24 B
Commit: 54f4af9

TasukuUno
TasukuUno commented Oct 9, 2020
View reviewed changes
test/integration/gssp-redirect/test/index.test.js

const text = await browser.elementByCss('#another').text()

expect(text).toEqual('another Page')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In first commit, I added them to the existing test cases because there are no any "expect" functions.

packages/next/next-server/lib/router/router.ts
destination,
options
)
return this.change(method, destination, destination, options)
Copy link
Contributor Author

@TasukuUno TasukuUno Oct 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous code, this replaced history of the origin page not the one with redirect settings with new page. So, I think it is better to use "pushState" for client-side navigation and use "replaceState" in the only case of first navigation of SSG.

ijjk
ijjk approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated history behavior and tests seem good, thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Oct 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
buildDuration 12.7s 13.1s ⚠️ +461ms
nodeModulesSize 91.3 MB 91.3 MB -83 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.394 2.457 ⚠️ +0.06
/ avg req/sec 1044.19 1017.4 ⚠️ -26.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.329 1.353 ⚠️ +0.02
/error-in-render avg req/sec 1881.25 1848.25 ⚠️ -33
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
677f882d2ed8..574c.js gzip 11.2 kB 11.2 kB ⚠️ +2 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ⚠️ +2 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
677f882d2ed8..dule.js gzip 7.02 kB 7.01 kB -1 B
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB -1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
index.html gzip 1 kB 1 kB -1 B
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 994 B -1 B
Overall change 3 kB 3 kB -2 B

Diffs

Diff for 677f882d2ed8..12.module.js 
@@ -1235,12 +1235,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                 this._resolveHref(parsedHref, pages);
 
                 if (pages.includes(parsedHref.pathname)) {
-                  return this.change(
-                    "replaceState",
-                    destination,
-                    destination,
-                    options
-                  );
+                  return this.change(method, destination, destination, options);
                 }
               }
Diff for 677f882d2ed8..d5962febf.js 
@@ -1539,7 +1539,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
                             return _context.abrupt(
                               "return",
                               this.change(
-                                "replaceState",
+                                method,
                                 destination,
                                 destination,
                                 options
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a4a3d644f73d852a2012.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c77303353820ee04bf6f.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.be11310f581d5962febf.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9ab79628c20d3412aee7.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a4a3d644f73d852a2012.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c77303353820ee04bf6f.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a4a3d644f73d852a2012.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c77303353820ee04bf6f.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -126,13 +126,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.be11310f581d5962febf.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9ab79628c20d3412aee7.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a4a3d644f73d852a2012.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c77303353820ee04bf6f.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a4a3d644f73d852a2012.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c77303353820ee04bf6f.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -121,13 +121,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.be11310f581d5962febf.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9ab79628c20d3412aee7.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a4a3d644f73d852a2012.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c77303353820ee04bf6f.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
buildDuration 14.9s 14.8s -96ms
nodeModulesSize 91.3 MB 91.3 MB -83 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
677f882d2ed8..574c.js gzip 11.2 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-2927f4e..281e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..d3ae.js gzip N/A 11.2 kB N/A
Overall change 58.3 kB 58.3 kB ⚠️ +2 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
677f882d2ed8..dule.js gzip 7.02 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1382a2d..dule.js gzip 6.32 kB 6.32 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 7.01 kB N/A
Overall change 53.1 kB 53.1 kB -1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary TasukuUno/next.js fix/client-redirect Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.1 MB 1.1 MB -8 B
routerDirect.js 1.1 MB 1.1 MB -8 B
withRouter.js 1.1 MB 1.1 MB -8 B
Overall change 5.43 MB 5.43 MB -24 B
Commit: ac6c27f

@ijjk ijjk merged commit 3f22490 into vercel:canary Oct 27, 2020
@TasukuUno
Copy link
Contributor Author

@ijjk thank you!!!

@TasukuUno TasukuUno deleted the fix/client-redirect branch October 27, 2020 05:16
This was referenced Oct 28, 2020
Open
Open
Open
This was referenced Mar 7, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 17, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 12, 2022
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 23, 2022
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

browser back issue of experimental redirects from getServerSideProps / getStaticProps
2 participants
@TasukuUno @ijjk