Remove multi-host support for image component and support quality pass-through #18038

atcastle · 2020-10-20T04:46:17Z

This PR removes support for multiple hosts from the image component, at @timneutkens suggestion. It also adds support for passing a "quality" parameter to the image component, which is passed through to the various loaders. Additionally, if you don't specify autoOptimize: false in the next.config, the loaders will add the relevant auto optimization parameters to the image URLs. CC: @styfle

ijjk · 2020-10-20T04:57:47Z

Failing test suites

Commit: 9c1c3b1

test/integration/image-component/bad-next-config/test/index.test.js

Next.config.js images prop without default host > Should error during build if images prop in next.config is malformed
Next.config.js images prop without path > Should error during build if images prop in next.config is malformed

Expand output

● Next.config.js images prop without default host › Should error during build if images prop in next.config is malformed

expect(received).toContain(expected) // indexOf

Expected substring: "If the image configuration property is present in next.config.js, it must have a host named \"default\""
Received string:    ""

  34 |   })
  35 |   it('Should error during build if images prop in next.config is malformed', () => {
> 36 |     expect(build.stderr).toContain(
     |                          ^
  37 |       'If the image configuration property is present in next.config.js, it must have a host named "default"'
  38 |     )
  39 |   })

  at Object.<anonymous> (integration/image-component/bad-next-config/test/index.test.js:36:26)

● Next.config.js images prop without path › Should error during build if images prop in next.config is malformed

expect(received).toContain(expected) // indexOf

Expected substring: "All hosts defined in the image configuration property of next.config.js must define a path"
Received string:    ""

  70 |   })
  71 |   it('Should error during build if images prop in next.config is malformed', () => {
> 72 |     expect(build.stderr).toContain(
     |                          ^
  73 |       'All hosts defined in the image configuration property of next.config.js must define a path'
  74 |     )
  75 |   })

  at Object.<anonymous> (integration/image-component/bad-next-config/test/index.test.js:72:26)

ijjk · 2020-10-20T14:20:41Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
buildDuration	13.5s	13.3s	-168ms
nodeModulesSize	64.5 MB	64.5 MB	-1.7 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.545	2.522	-0.02
/ avg req/sec	982.5	991.3	+8.8
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.414	1.321	-0.09
/error-in-render avg req/sec	1767.71	1893.15	+125.44

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
677f882d2ed8..35e7.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-4622877..6010.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e9d8820..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
buildDuration	15s	15.2s	⚠️ +212ms
nodeModulesSize	64.5 MB	64.5 MB	-1.7 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
677f882d2ed8..35e7.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-4622877..6010.js gzip	7.34 kB	7.34 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
677f882d2ed8..dule.js gzip	6.94 kB	6.94 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e9d8820..dule.js gzip	6.32 kB	6.32 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-89ad9e7..25bb.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.74 kB	7.74 kB	✓

Client Pages Modern

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-aeb707b..dule.js gzip	1.29 kB	1.29 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.39 kB	5.39 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	azukaru/next.js image-component-remove-hosts	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.42 MB	5.42 MB	✓

Commit: 9c1c3b1

atcastle added 3 commits October 19, 2020 17:02

Fix flaky scroll tests for image component

6d8643e

Remove logic for multiple hosts

ae40797

Make image quality for loaders configurable with attributes

9c1c3b1

atcastle requested review from ijjk, lfades, Timer and timneutkens as code owners October 20, 2020 04:46

ijjk added the type: next label Oct 20, 2020

styfle previously approved these changes Oct 20, 2020

View reviewed changes

Remove unneeded tests

f269565

timneutkens dismissed styfle’s stale review via f269565 October 20, 2020 14:27

timneutkens merged commit 01e6bd1 into vercel:canary Oct 20, 2020

timneutkens deleted the image-component-remove-hosts branch October 20, 2020 14:28

ijjk added the hacktoberfest-accepted label Oct 20, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove multi-host support for image component and support quality pass-through #18038

Remove multi-host support for image component and support quality pass-through #18038

atcastle commented Oct 20, 2020

ijjk commented Oct 20, 2020

ijjk commented Oct 20, 2020

Remove multi-host support for image component and support quality pass-through #18038

Remove multi-host support for image component and support quality pass-through #18038

Conversation

atcastle commented Oct 20, 2020

ijjk commented Oct 20, 2020

Failing test suites

ijjk commented Oct 20, 2020

Stats from current PR