-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @ampproject/toolbox-optimizer to 2.7.0-alpha.4 #18248
Conversation
This version has uses node-fetch v2.6.1 Related to #17416
Failing test suitesCommit: 1c583b6 test/integration/amp-export-validation/test/index.test.js
Expand output● AMP Validation on Export › should export AMP pages
test/integration/amphtml-custom-optimizer/test/index.test.js
Expand output● AMP Custom Optimizer › should build and start for static page
● AMP Custom Optimizer › should build and start for dynamic page
test/integration/amphtml-custom-validator/test/index.test.js
Expand output● AMP Custom Validator › should build and start successfully
● AMP Custom Validator › should run in dev mode successfully
test/integration/auto-export-query-error/test/index.test.js
Expand output● Auto Export › server mode › should show warning for query provided for auto exported page correctly
● Auto Export › serverless mode › should show warning for query provided for auto exported page correctly
test/integration/build-output/test/index.test.js
Expand output● Build Output › With AMP Output › should not include custom error
test/integration/basepath/test/index.test.js
Expand output● basePath production › should add basePath to routes-manifest
● basePath production › should prefetch pages correctly when manually called
● basePath production › should prefetch pages correctly in viewport with
● basePath production › should 404 for public file without basePath
● basePath production › should serve public file with basePath correctly
● basePath production › should rewrite with basePath by default
● basePath production › should not rewrite without basePath without disabling
● basePath production › should not rewrite with basePath when set to false
● basePath production › should rewrite without basePath when set to false
● basePath production › should redirect with basePath by default
● basePath production › should not redirect without basePath without disabling
● basePath production › should not redirect with basePath when set to false
● basePath production › should redirect without basePath when set to false
● basePath production › should add header with basePath by default
● basePath production › should not add header without basePath without disabling
● basePath production › should not add header with basePath when set to false
● basePath production › should add header without basePath when set to false
● basePath production › should not update URL for a 404
● basePath production › should handle 404 urls that start with basePath
● basePath production › should navigate back to a non-basepath 404 that starts with basepath
● basePath production › should update dynamic params after mount correctly
● basePath production › should navigate to index page with getStaticProps
● basePath production › should navigate to nested index page with getStaticProps
● basePath production › should work with nested folder with same name as basePath
● basePath production › should work with normal dynamic page
● basePath production › should work with hash links
● basePath production › should work with catch-all page
● basePath production › should redirect trailing slash correctly
● basePath production › should redirect trailing slash on root correctly
● basePath production › should navigate an absolute url
● basePath production › should navigate an absolute local url with basePath
● basePath production › should navigate an absolute local url without basePath
● basePath production › should 404 when manually adding basePath with
● basePath production › should 404 when manually adding basePath with router.push
● basePath production › should 404 when manually adding basePath with router.replace
● basePath production › should show the hello page under the /docs prefix
● basePath production › should have correct router paths on first load of /
● basePath production › should have correct router paths on first load of /hello
● basePath production › should fetch data for getStaticProps without reloading
● basePath production › should fetch data for getServerSideProps without reloading
● basePath production › should have correct href for a link
● basePath production › should have correct href for a link to /
● basePath production › should show 404 for page not under the /docs prefix
● basePath production › should show the other-page page under the /docs prefix
● basePath production › should have basePath field on Router
● basePath production › should navigate to the page without refresh
● basePath production › should use urls with basepath in router events
● basePath production › should use urls with basepath in router events for hash changes
● basePath production › should use urls with basepath in router events for cancelled routes
● basePath production › should use urls with basepath in router events for failed route change
● basePath production › should allow URL query strings without refresh
● basePath production › should correctly replace state when same asPath but different url
● basePath production › should respect basePath in amphtml link rel
● basePath serverless › should add basePath to routes-manifest
● basePath serverless › should prefetch pages correctly when manually called
● basePath serverless › should prefetch pages correctly in viewport with
● basePath serverless › should 404 for public file without basePath
● basePath serverless › should serve public file with basePath correctly
● basePath serverless › should rewrite with basePath by default
● basePath serverless › should not rewrite without basePath without disabling
● basePath serverless › should not rewrite with basePath when set to false
● basePath serverless › should rewrite without basePath when set to false
● basePath serverless › should redirect with basePath by default
● basePath serverless › should not redirect without basePath without disabling
● basePath serverless › should not redirect with basePath when set to false
● basePath serverless › should redirect without basePath when set to false
● basePath serverless › should add header with basePath by default
● basePath serverless › should not add header without basePath without disabling
● basePath serverless › should not add header with basePath when set to false
● basePath serverless › should add header without basePath when set to false
● basePath serverless › should not update URL for a 404
● basePath serverless › should handle 404 urls that start with basePath
● basePath serverless › should navigate back to a non-basepath 404 that starts with basepath
● basePath serverless › should update dynamic params after mount correctly
● basePath serverless › should navigate to index page with getStaticProps
● basePath serverless › should navigate to nested index page with getStaticProps
● basePath serverless › should work with nested folder with same name as basePath
● basePath serverless › should work with normal dynamic page
● basePath serverless › should work with hash links
● basePath serverless › should work with catch-all page
● basePath serverless › should redirect trailing slash correctly
● basePath serverless › should redirect trailing slash on root correctly
● basePath serverless › should navigate an absolute url
● basePath serverless › should navigate an absolute local url with basePath
● basePath serverless › should navigate an absolute local url without basePath
● basePath serverless › should 404 when manually adding basePath with
● basePath serverless › should 404 when manually adding basePath with router.push
● basePath serverless › should 404 when manually adding basePath with router.replace
● basePath serverless › should show the hello page under the /docs prefix
● basePath serverless › should have correct router paths on first load of /
● basePath serverless › should have correct router paths on first load of /hello
● basePath serverless › should fetch data for getStaticProps without reloading
● basePath serverless › should fetch data for getServerSideProps without reloading
● basePath serverless › should have correct href for a link
● basePath serverless › should have correct href for a link to /
● basePath serverless › should show 404 for page not under the /docs prefix
● basePath serverless › should show the other-page page under the /docs prefix
● basePath serverless › should have basePath field on Router
● basePath serverless › should navigate to the page without refresh
● basePath serverless › should use urls with basepath in router events
● basePath serverless › should use urls with basepath in router events for hash changes
● basePath serverless › should use urls with basepath in router events for cancelled routes
● basePath serverless › should use urls with basepath in router events for failed route change
● basePath serverless › should allow URL query strings without refresh
● basePath serverless › should correctly replace state when same asPath but different url
● basePath serverless › should always strip basePath in serverless-loader
● Test suite failed to run
● Test suite failed to run
|
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
buildDuration | 10.4s | 11.7s | |
nodeModulesSize | 91.3 MB | 91.3 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.956 | 2.091 | |
/ avg req/sec | 1277.82 | 1195.75 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.08 | 1.151 | |
/error-in-render avg req/sec | 2315.1 | 2172.57 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
677f882d2ed8..574c.js gzip | 11.2 kB | 11.2 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-3dd37a4..54de.js gzip | 7.34 kB | 7.34 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 58.3 kB | 58.3 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.02 kB | 7.02 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-082aff9..dule.js gzip | 6.32 kB | 6.32 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
_app-9a0b9e1..b37e.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-ed1b0..8fbd.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-89731c..c609.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-41ceea0..6b62.js gzip | 1.35 kB | 1.35 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 7.75 kB | 7.75 kB | ✓ |
Client Pages Modern
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-2d41a89..dule.js gzip | 1.31 kB | 1.31 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
Overall change | 5.4 kB | 5.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
_buildManife..dule.js gzip | 329 B | 329 B | ✓ |
Overall change | 652 B | 652 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
index.html gzip | 1 kB | 1 kB | ✓ |
link.html gzip | 1.01 kB | 1.01 kB | ✓ |
withRouter.html gzip | 994 B | 994 B | ✓ |
Overall change | 3 kB | 3 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
buildDuration | 12.8s | 12.9s | |
nodeModulesSize | 91.3 MB | 91.3 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
677f882d2ed8..574c.js gzip | 11.2 kB | 11.2 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-3dd37a4..54de.js gzip | 7.34 kB | 7.34 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 58.3 kB | 58.3 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.02 kB | 7.02 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-082aff9..dule.js gzip | 6.32 kB | 6.32 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
_app-9a0b9e1..b37e.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-ed1b0..8fbd.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-89731c..c609.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-41ceea0..6b62.js gzip | 1.35 kB | 1.35 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 7.75 kB | 7.75 kB | ✓ |
Client Pages Modern
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-2d41a89..dule.js gzip | 1.31 kB | 1.31 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
Overall change | 5.4 kB | 5.4 kB | ✓ |
Client Build Manifests
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
_buildManifest.js gzip | 323 B | 323 B | ✓ |
_buildManife..dule.js gzip | 329 B | 329 B | ✓ |
Overall change | 652 B | 652 B | ✓ |
Serverless bundles
vercel/next.js canary | omBratteng/next.js upgrade-amp-toolbox-optimizer | Change | |
---|---|---|---|
_error.js | 1.06 MB | 1.06 MB | ✓ |
404.html | 4.73 kB | 4.73 kB | ✓ |
hooks.html | 3.92 kB | 3.92 kB | ✓ |
index.js | 1.06 MB | 1.06 MB | ✓ |
link.js | 1.1 MB | 1.1 MB | ✓ |
routerDirect.js | 1.1 MB | 1.1 MB | ✓ |
withRouter.js | 1.1 MB | 1.1 MB | ✓ |
Overall change | 5.42 MB | 5.42 MB | ✓ |
This version has uses node-fetch v2.6.1
Fixes #18044
Related to #17416