Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add apollo state func #18436

Closed
wants to merge 1 commit into from
Closed

add apollo state func #18436

wants to merge 1 commit into from

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Oct 29, 2020 •
edited
Loading

The intention is to show people the correlation between things, in this case, understand the usage of the same key from the props and the rehydration.

Hopefully, this change will bring value as it has done with some Juniors already.

@ijjk ijjk added the examples Issue was opened via the examples template. label Oct 29, 2020
@ijjk
Copy link
Member

ijjk commented Oct 29, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
buildDuration 11.9s 11.8s -93ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.261 2.383 ⚠️ +0.12
/ avg req/sec 1105.49 1048.93 ⚠️ -56.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.196 1.247 ⚠️ +0.05
/error-in-render avg req/sec 2090.21 2004.47 ⚠️ -85.74
Client Bundles (main, webpack, commons)
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-fc2ed98..cd2b.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-20f9619..dule.js gzip 6.31 kB 6.31 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
buildDuration 13.1s 13.3s ⚠️ +224ms
nodeModulesSize 91.3 MB 91.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-fc2ed98..cd2b.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-20f9619..dule.js gzip 6.31 kB 6.31 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.4 kB 5.4 kB ✓
Client Build Manifests
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary yordis/next.js yordis/with-apollo-proposal Change
_error.js 1.06 MB 1.06 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.06 MB 1.06 MB ✓
link.js 1.11 MB 1.11 MB ✓
routerDirect.js 1.1 MB 1.1 MB ✓
withRouter.js 1.1 MB 1.1 MB ✓
Overall change 5.43 MB 5.43 MB ✓
Commit: be3ccc5

@yordis yordis marked this pull request as ready for review November 9, 2020 10:32
lfades
lfades reviewed Nov 12, 2020
View reviewed changes
examples/with-apollo/lib/apolloClient.js
Comment on lines +49 to +55
return {
...pageProps,
props: {
...pageProps.props,
[APOLLO_STATE_PROP_NAME]: client.cache.extract(),
},
}
Copy link
Member

@lfades lfades Nov 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be easier to understand and provider the same result, just an idea, you don't have to merge it.

This also has the added benefit that if you don't define props: {} then it won't be added to pageProps and Next.js will throw as expected.

Suggested change
return {
...pageProps,
props: {
...pageProps.props,
[APOLLO_STATE_PROP_NAME]: client.cache.extract(),
},
}
if (pageProps?.props) {
pageProps.props[APOLLO_STATE_PROP_NAME] = client.cache.extract()
}
return pageProps

lfades
lfades reviewed Nov 12, 2020
View reviewed changes
examples/with-apollo/lib/apolloClient.js
export function useApollo(pageProps) {
const store = useMemo(
() => initializeApollo(pageProps[APOLLO_STATE_PROP_NAME]),
[pageProps]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[pageProps]
[pageProps[APOLLO_STATE_PROP_NAME]]

lfades
lfades requested changes Nov 12, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yordis Hi there 👋 and thank you for the PR.

Added some suggestions!

@yordis
Copy link
Contributor Author

yordis commented Nov 13, 2020

Hey @lfades I removed my repo, so I had to create a new PR: #19137

Let's move the conversation there, please.

@lfades
Copy link
Member

lfades commented Nov 15, 2020 •
edited
Loading

Closing due to #18436 (comment)

@lfades lfades closed this Nov 15, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades requested changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yordis @ijjk @lfades