Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect next/babel user provided runtime option #19136

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Nov 13, 2020

Closes #18847
Fixes #18096
Fixes #18553

@vercel vercel bot temporarily deployed to Preview November 13, 2020 05:50 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
buildDuration 13.6s 13.4s -230ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +502 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
/ failed reqs 0 0
/ total time (seconds) 2.554 2.454 -0.1
/ avg req/sec 978.83 1018.56 +39.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.327 1.307 -0.02
/error-in-render avg req/sec 1883.28 1913.29 +30.01
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-b0b971f..64a5.js gzip 6.5 kB 6.5 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.9 kB 58.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-22cb0cf..dule.js gzip 5.61 kB 5.61 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.6 kB 53.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.98 kB 7.98 kB
Client Pages Modern
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-973cce3..dule.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.6 kB 5.6 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
index.html gzip 971 B 971 B
link.html gzip 978 B 978 B
withRouter.html gzip 965 B 965 B
Overall change 2.91 kB 2.91 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
buildDuration 15.1s 14.9s -181ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +502 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-b0b971f..64a5.js gzip 6.5 kB 6.5 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.9 kB 58.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-22cb0cf..dule.js gzip 5.61 kB 5.61 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.6 kB 53.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.98 kB 7.98 kB
Client Pages Modern
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-973cce3..dule.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.6 kB 5.6 kB
Client Build Manifests
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary Timer/next.js feat/preset-react-runtime Change
_error.js 916 kB 916 kB
404.html 4.61 kB 4.61 kB
hooks.html 3.86 kB 3.86 kB
index.js 916 kB 916 kB
link.js 974 kB 974 kB
routerDirect.js 967 kB 967 kB
withRouter.js 967 kB 967 kB
Overall change 4.75 MB 4.75 MB
Commit: e19fee0

@Timer Timer merged commit 415d7fd into vercel:canary Nov 13, 2020
@Timer Timer deleted the feat/preset-react-runtime branch November 13, 2020 07:41
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants