Add locale: false for custom-routes + i18n #19164

ijjk · 2020-11-14T01:46:22Z

This mirrors the basePath: false behavior for custom-routes with locale: false to allow users to configure the locales manually (locale: false) or have the locales be handled automatically for custom-routes.

Fixes: #18927
Fixes: #18795

ijjk · 2020-11-14T01:55:04Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
buildDuration	12.4s	12.3s	-114ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +8.9 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.271	2.236	-0.03
/ avg req/sec	1100.63	1118.03	+17.4
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.207	1.217	⚠️ +0.01
/error-in-render avg req/sec	2071.49	2054.59	⚠️ -16.9

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
677f882d2ed8..d9fb.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a715f78..8dec.js gzip	6.53 kB	6.53 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
677f882d2ed8..dule.js gzip	8.23 kB	8.23 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1ab332d..dule.js gzip	5.64 kB	5.64 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.6 kB	53.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d9a15a0..130a.js gzip	1.57 kB	1.57 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.98 kB	7.98 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-973cce3..dule.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.6 kB	5.6 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
index.html gzip	969 B	969 B	✓
link.html gzip	975 B	975 B	✓
withRouter.html gzip	961 B	961 B	✓
Overall change	2.9 kB	2.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
buildDuration	13.9s	13.9s	-49ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +8.9 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
677f882d2ed8..d9fb.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a715f78..8dec.js gzip	6.53 kB	6.53 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
677f882d2ed8..dule.js gzip	8.23 kB	8.23 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1ab332d..dule.js gzip	5.64 kB	5.64 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.6 kB	53.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d9a15a0..130a.js gzip	1.57 kB	1.57 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.98 kB	7.98 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-973cce3..dule.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.6 kB	5.6 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_error.js	916 kB	917 kB	⚠️ +1.37 kB
404.html	4.61 kB	4.61 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	916 kB	918 kB	⚠️ +1.37 kB
link.js	975 kB	976 kB	⚠️ +1.37 kB
routerDirect.js	967 kB	969 kB	⚠️ +1.37 kB
withRouter.js	967 kB	969 kB	⚠️ +1.37 kB
Overall change	4.75 MB	4.76 MB	⚠️ +6.84 kB

Commit: a1ec8f7

ijjk · 2020-11-14T02:15:20Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
buildDuration	13s	13.1s	⚠️ +136ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +9.37 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.439	2.358	-0.08
/ avg req/sec	1024.96	1060.06	+35.1
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.302	1.247	-0.05
/error-in-render avg req/sec	1920.43	2005.38	+84.95

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
677f882d2ed8..d9fb.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a715f78..8dec.js gzip	6.53 kB	6.53 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
677f882d2ed8..dule.js gzip	8.23 kB	8.23 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1ab332d..dule.js gzip	5.64 kB	5.64 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.6 kB	53.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d9a15a0..130a.js gzip	1.57 kB	1.57 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.98 kB	7.98 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-973cce3..dule.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.6 kB	5.6 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
index.html gzip	969 B	969 B	✓
link.html gzip	975 B	975 B	✓
withRouter.html gzip	961 B	961 B	✓
Overall change	2.9 kB	2.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
buildDuration	15s	15s	⚠️ +18ms
nodeModulesSize	84.9 MB	84.9 MB	⚠️ +9.37 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
677f882d2ed8..d9fb.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a715f78..8dec.js gzip	6.53 kB	6.53 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
677f882d2ed8..dule.js gzip	8.23 kB	8.23 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1ab332d..dule.js gzip	5.64 kB	5.64 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.6 kB	53.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d9a15a0..130a.js gzip	1.57 kB	1.57 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.98 kB	7.98 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-973cce3..dule.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.6 kB	5.6 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	651 B	651 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/custom-routes	Change
_error.js	916 kB	917 kB	⚠️ +1.46 kB
404.html	4.61 kB	4.61 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	916 kB	918 kB	⚠️ +1.46 kB
link.js	975 kB	976 kB	⚠️ +1.46 kB
routerDirect.js	967 kB	969 kB	⚠️ +1.46 kB
withRouter.js	967 kB	969 kB	⚠️ +1.46 kB
Overall change	4.75 MB	4.76 MB	⚠️ +7.31 kB

Commit: e2e6bc1

ijjk added 2 commits November 13, 2020 19:40

Add locale: false for custom-routes + i18n

912d790

Merge remote-tracking branch 'upstream/canary' into i18n/custom-routes

a1ec8f7

ijjk requested review from chibicode, lfades, Timer and timneutkens as code owners November 14, 2020 01:46

ijjk added type: documentation type: next labels Nov 14, 2020

vercel bot temporarily deployed to Preview November 14, 2020 01:46 Inactive

ijjk added 2 commits November 13, 2020 20:05

Update test and add check

24ba836

Merge remote-tracking branch 'upstream/canary' into i18n/custom-routes

e2e6bc1

vercel bot temporarily deployed to Preview November 14, 2020 02:05 Inactive

ijjk mentioned this pull request Nov 14, 2020

[next] Ensure correct route order for i18n + custom-routes vercel/vercel#5421

Merged

Timer approved these changes Nov 14, 2020

View reviewed changes

kodiakhq bot merged commit 1e61b69 into vercel:canary Nov 14, 2020

Timer deleted the i18n/custom-routes branch November 14, 2020 03:36

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add locale: false for custom-routes + i18n #19164

Add locale: false for custom-routes + i18n #19164

ijjk commented Nov 14, 2020 •

edited

Loading

ijjk commented Nov 14, 2020

ijjk commented Nov 14, 2020

Add locale: false for custom-routes + i18n #19164

Add locale: false for custom-routes + i18n #19164

Conversation

ijjk commented Nov 14, 2020 • edited Loading

ijjk commented Nov 14, 2020

Stats from current PR

ijjk commented Nov 14, 2020

Stats from current PR

ijjk commented Nov 14, 2020 •

edited

Loading