Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded to chakra V1 #19181

Merged
merged 6 commits into from
Nov 16, 2020
Merged

Upgraded to chakra V1 #19181

merged 6 commits into from
Nov 16, 2020

Conversation

mzaien
Copy link
Contributor

@mzaien mzaien commented Nov 15, 2020

Upgraded charkra ui and peer dep and fixed the icon to follow the new api

Upgraded to chakra V1
3544ca6 
Upgraded charkra ui and peer dep and fixed the icon to follow the new api
@ijjk ijjk added the examples Issue was opened via the examples template. label Nov 15, 2020
@ijjk
Copy link
Member

ijjk commented Nov 15, 2020 •
edited
Loading

Failing test suites

Commit: 3544ca6

test/integration/dist-dir/test/index.test.js

  • distDir > should handle null/undefined distDir
  • distDir > With basic usage > should not build the app within the default .next directory
Expand output

● distDir › With basic usage › should not build the app within the default .next directory

expect(received).toBeFalsy()

Received: true

  40 |       expect(
  41 |         await fs.exists(join(__dirname, `/../.next/${BUILD_ID_FILE}`))
> 42 |       ).toBeFalsy()
     |         ^
  43 |     })
  44 |   })
  45 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:42:9)

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 189

  61 |     await fs.writeFile(nextConfig, origNextConfig)
  62 | 
> 63 |     expect(stderr.length).toBe(0)
     |                           ^
  64 |   })
  65 | })
  66 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:63:27)

test/integration/cli/test/index.test.js

  • CLI Usage > start > experimental react version
  • CLI Usage > start > experimental react-dom version
Expand output

● CLI Usage › start › experimental react version

expect(received).not.toMatch(expected)

Expected substring: not "outdated"
Received string:        "Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
"

  274 | 
  275 |       expect(stderr).not.toMatch('disabled')
> 276 |       expect(stderr).not.toMatch('outdated')
      |                          ^
  277 |       expect(stderr).not.toMatch(`react-dom`)
  278 | 
  279 |       await killApp(instance)

  at Object.<anonymous> (integration/cli/test/index.test.js:276:26)

● CLI Usage › start › experimental react-dom version

expect(received).not.toMatch(expected)

Expected substring: not "outdated"
Received string:        "Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
"

  292 | 
  293 |       expect(stderr).not.toMatch('disabled')
> 294 |       expect(stderr).not.toMatch('outdated')
      |                          ^
  295 |       expect(stderr).not.toMatch('`react`')
  296 | 
  297 |       await killApp(instance)

  at Object.<anonymous> (integration/cli/test/index.test.js:294:26)

test/integration/production-build-dir/test/index.test.js

  • Production Custom Build Directory > With basic usage > should render the page
Expand output

● Production Custom Build Directory › With basic usage › should render the page

expect(received).toBe(expected) // Object.is equality

Expected: ""
Received: "Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db·
Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
"

  20 |         stderr: true,
  21 |       })
> 22 |       expect(result.stderr).toBe('')
     |                             ^
  23 | 
  24 |       const app = nextServer({
  25 |         dir: join(__dirname, '../build'),

  at Object.<anonymous> (integration/production-build-dir/test/index.test.js:22:29)

@ijjk
Copy link
Member

ijjk commented Nov 15, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Mzaien/next.js Chakra-stable Change
buildDuration 12.6s 12.6s ⚠️ +25ms
nodeModulesSize 85 MB 85 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Mzaien/next.js Chakra-stable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.351 2.316 -0.04
/ avg req/sec 1063.56 1079.41 +15.85
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.273 1.239 -0.03
/error-in-render avg req/sec 1963.1 2017.56 +54.46
Client Bundles (main, webpack, commons)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b336ff..ab65.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-878859a..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Mzaien/next.js Chakra-stable Change
index.html gzip 968 B 968 B ✓
link.html gzip 975 B 975 B ✓
withRouter.html gzip 962 B 962 B ✓
Overall change 2.9 kB 2.9 kB ✓
Serverless Mode
General
vercel/next.js canary Mzaien/next.js Chakra-stable Change
buildDuration 14.4s 14.7s ⚠️ +261ms
nodeModulesSize 85 MB 85 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b336ff..ab65.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-878859a..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_error.js 918 kB 918 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 918 kB 918 kB ✓
link.js 976 kB 976 kB ✓
routerDirect.js 969 kB 969 kB ✓
withRouter.js 969 kB 969 kB ✓
Overall change 4.76 MB 4.76 MB ✓
Commit: 3544ca6

@ijjk
Copy link
Member

ijjk commented Nov 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Mzaien/next.js Chakra-stable Change
buildDuration 13.2s 13.3s ⚠️ +78ms
nodeModulesSize 85 MB 85 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Mzaien/next.js Chakra-stable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.505 2.534 ⚠️ +0.03
/ avg req/sec 998.18 986.41 ⚠️ -11.77
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.279 1.299 ⚠️ +0.02
/error-in-render avg req/sec 1954.93 1924.23 ⚠️ -30.7
Client Bundles (main, webpack, commons)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b336ff..ab65.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-878859a..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Mzaien/next.js Chakra-stable Change
index.html gzip 968 B 968 B ✓
link.html gzip 975 B 975 B ✓
withRouter.html gzip 962 B 962 B ✓
Overall change 2.9 kB 2.9 kB ✓
Serverless Mode
General
vercel/next.js canary Mzaien/next.js Chakra-stable Change
buildDuration 14.7s 14.9s ⚠️ +226ms
nodeModulesSize 85 MB 85 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b336ff..ab65.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-878859a..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_error.js 918 kB 918 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 918 kB 918 kB ✓
link.js 976 kB 976 kB ✓
routerDirect.js 969 kB 969 kB ✓
withRouter.js 969 kB 969 kB ✓
Overall change 4.76 MB 4.76 MB ✓
Commit: c7426de

@ijjk
Copy link
Member

ijjk commented Nov 15, 2020 •
edited
Loading

Failing test suites

Commit: c7426de

test/integration/dist-dir/test/index.test.js

  • distDir > should handle null/undefined distDir
  • distDir > With basic usage > should not build the app within the default .next directory
Expand output

● distDir › With basic usage › should not build the app within the default .next directory

expect(received).toBeFalsy()

Received: true

  40 |       expect(
  41 |         await fs.exists(join(__dirname, `/../.next/${BUILD_ID_FILE}`))
> 42 |       ).toBeFalsy()
     |         ^
  43 |     })
  44 |   })
  45 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:42:9)

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 189

  61 |     await fs.writeFile(nextConfig, origNextConfig)
  62 | 
> 63 |     expect(stderr.length).toBe(0)
     |                           ^
  64 |   })
  65 | })
  66 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:63:27)

test/integration/re-export-all-exports-from-page-disallowed/test/index.test.js

  • Re-export all exports from page is disallowed > shows error when a page re-export all exports
Expand output

● Re-export all exports from page is disallowed › shows error when a page re-export all exports

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `Re-export all exports from page is disallowed shows error when a page re-export all exports 1`

- Snapshot  - 3
+ Received  + 3

- ./pages/contact.js:3:1
- Syntax error: Using `export * from '...'` in a page is disallowed. Please use `export { default } from '...'` instead.
- Read more: https://err.sh/next.js/export-all-in-page
+ Why you should do it regularly:
+ https://github.com/browserslist/browserslist#browsers-data-updating
+ Failed to compile.

  15 |     expect(stderr).toMatch(/https:\/\/err\.sh\/next\.js\/export-all-in-page/)
  16 | 
> 17 |     expect(stderr.split('\n\n')[1]).toMatchInlineSnapshot(`
     |                                     ^
  18 |       "./pages/contact.js:3:1
  19 |       Syntax error: Using \`export * from '...'\` in a page is disallowed. Please use \`export { default } from '...'\` instead.
  20 |       Read more: https://err.sh/next.js/export-all-in-page"

  at Object.<anonymous> (integration/re-export-all-exports-from-page-disallowed/test/index.test.js:17:37)

@vercel vercel bot temporarily deployed to Preview November 15, 2020 19:12 Inactive
lfades
lfades approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzaien Hi there 👋 and thank you for the PR. Looks great!

@ijjk
Copy link
Member

ijjk commented Nov 15, 2020 •
edited
Loading

Failing test suites

Commit: 6a6c00f

test/integration/dist-dir/test/index.test.js

  • distDir > should handle null/undefined distDir
  • distDir > With basic usage > should not build the app within the default .next directory
Expand output

● distDir › With basic usage › should not build the app within the default .next directory

expect(received).toBeFalsy()

Received: true

  40 |       expect(
  41 |         await fs.exists(join(__dirname, `/../.next/${BUILD_ID_FILE}`))
> 42 |       ).toBeFalsy()
     |         ^
  43 |     })
  44 |   })
  45 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:42:9)

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 189

  61 |     await fs.writeFile(nextConfig, origNextConfig)
  62 | 
> 63 |     expect(stderr.length).toBe(0)
     |                           ^
  64 |   })
  65 | })
  66 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:63:27)

test/integration/cli/test/index.test.js

  • CLI Usage > start > experimental react version
  • CLI Usage > start > experimental react-dom version
Expand output

● CLI Usage › start › experimental react version

expect(received).not.toMatch(expected)

Expected substring: not "outdated"
Received string:        "Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
"

  274 | 
  275 |       expect(stderr).not.toMatch('disabled')
> 276 |       expect(stderr).not.toMatch('outdated')
      |                          ^
  277 |       expect(stderr).not.toMatch(`react-dom`)
  278 | 
  279 |       await killApp(instance)

  at Object.<anonymous> (integration/cli/test/index.test.js:276:26)

● CLI Usage › start › experimental react-dom version

expect(received).not.toMatch(expected)

Expected substring: not "outdated"
Received string:        "Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
"

  292 | 
  293 |       expect(stderr).not.toMatch('disabled')
> 294 |       expect(stderr).not.toMatch('outdated')
      |                          ^
  295 |       expect(stderr).not.toMatch('`react`')
  296 | 
  297 |       await killApp(instance)

  at Object.<anonymous> (integration/cli/test/index.test.js:294:26)

test/integration/not-found-revalidate/test/index.test.js

  • SSG notFound revalidate > production mode > should revalidate after notFound is returned for fallback: blocking
Expand output

● SSG notFound revalidate › production mode › should revalidate after notFound is returned for fallback: blocking

expect(received).not.toBe(expected) // Object.is equality

Expected: not 0.7610442647627536

  64 |     expect(props2.params).toEqual({ slug: 'hello' })
  65 |     expect(isNaN(props2.random)).toBe(false)
> 66 |     expect(props2.random).not.toBe(props.random)
     |                               ^
  67 |   })
  68 | 
  69 |   it('should revalidate after notFound is returned for fallback: true', async () => {

  at Object.<anonymous> (integration/not-found-revalidate/test/index.test.js:66:31)

@ijjk
Copy link
Member

ijjk commented Nov 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Mzaien/next.js Chakra-stable Change
buildDuration 13.8s 14s ⚠️ +237ms
nodeModulesSize 85 MB 85 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Mzaien/next.js Chakra-stable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.613 2.64 ⚠️ +0.03
/ avg req/sec 956.77 946.88 ⚠️ -9.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.552 1.612 ⚠️ +0.06
/error-in-render avg req/sec 1611.31 1551.04 ⚠️ -60.27
Client Bundles (main, webpack, commons)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b336ff..ab65.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-878859a..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Mzaien/next.js Chakra-stable Change
index.html gzip 968 B 968 B ✓
link.html gzip 975 B 975 B ✓
withRouter.html gzip 962 B 962 B ✓
Overall change 2.9 kB 2.9 kB ✓
Serverless Mode
General
vercel/next.js canary Mzaien/next.js Chakra-stable Change
buildDuration 15.8s 15s -711ms
nodeModulesSize 85 MB 85 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b336ff..ab65.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-878859a..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_error.js 918 kB 918 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 918 kB 918 kB ✓
link.js 976 kB 976 kB ✓
routerDirect.js 969 kB 969 kB ✓
withRouter.js 969 kB 969 kB ✓
Overall change 4.76 MB 4.76 MB ✓
Commit: 6a6c00f

leerob
leerob approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@vercel vercel bot temporarily deployed to Preview November 16, 2020 14:54 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Mzaien/next.js Chakra-stable Change
buildDuration 11.4s 11.6s ⚠️ +172ms
nodeModulesSize 85 MB 85 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Mzaien/next.js Chakra-stable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.114 2.15 ⚠️ +0.04
/ avg req/sec 1182.46 1162.78 ⚠️ -19.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.184 1.211 ⚠️ +0.03
/error-in-render avg req/sec 2111.46 2064.92 ⚠️ -46.54
Client Bundles (main, webpack, commons)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..776c.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-95c0df2..6c91.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..dule.js gzip 8.26 kB 8.26 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8ead8dd..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Mzaien/next.js Chakra-stable Change
index.html gzip 968 B 968 B ✓
link.html gzip 974 B 974 B ✓
withRouter.html gzip 961 B 961 B ✓
Overall change 2.9 kB 2.9 kB ✓
Serverless Mode
General
vercel/next.js canary Mzaien/next.js Chakra-stable Change
buildDuration 13.3s 13.1s -285ms
nodeModulesSize 85 MB 85 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..776c.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-95c0df2..6c91.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
677f882d2ed8..dule.js gzip 8.26 kB 8.26 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8ead8dd..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Mzaien/next.js Chakra-stable Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary Mzaien/next.js Chakra-stable Change
_error.js 918 kB 918 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 918 kB 918 kB ✓
link.js 976 kB 976 kB ✓
routerDirect.js 969 kB 969 kB ✓
withRouter.js 969 kB 969 kB ✓
Overall change 4.76 MB 4.76 MB ✓
Commit: 27d3656

@kodiakhq kodiakhq bot merged commit 208551f into vercel:canary Nov 16, 2020
@mzaien
Copy link
Contributor Author

mzaien commented Nov 16, 2020

Thank you @lfades , @leerob it was my pleasure to be a contributor to Next.js 🙏

@mzaien mzaien deleted the Chakra-stable branch March 31, 2021 12:14
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@leerob leerob leerob approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzaien @ijjk @lfades @leerob