Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-magic example #19207

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Update with-magic example #19207

merged 3 commits into from
Nov 16, 2020

Conversation

paul-vd
Copy link
Contributor

@paul-vd paul-vd commented Nov 16, 2020

fixes the event argument inside the function call

  • argument is e but event was used instead

@paul-vd
Update login.js
74463ca 
fix naming for event argument
@ijjk ijjk added the examples Issue was opened via the examples template. label Nov 16, 2020
@ijjk
Copy link
Member

ijjk commented Nov 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary PaulPCIO/next.js patch-5 Change
buildDuration 13.7s 13.5s -226ms
nodeModulesSize 85 MB 85 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary PaulPCIO/next.js patch-5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.493 2.427 -0.07
/ avg req/sec 1002.79 1030.2 +27.41
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.32 1.303 -0.02
/error-in-render avg req/sec 1893.23 1918.46 +25.23
Client Bundles (main, webpack, commons)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..776c.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-95c0df2..6c91.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..dule.js gzip 8.26 kB 8.26 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8ead8dd..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary PaulPCIO/next.js patch-5 Change
index.html gzip 968 B 968 B ✓
link.html gzip 974 B 974 B ✓
withRouter.html gzip 961 B 961 B ✓
Overall change 2.9 kB 2.9 kB ✓
Serverless Mode
General
vercel/next.js canary PaulPCIO/next.js patch-5 Change
buildDuration 15.4s 15.6s ⚠️ +223ms
nodeModulesSize 85 MB 85 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..776c.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-95c0df2..6c91.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..dule.js gzip 8.26 kB 8.26 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8ead8dd..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_error.js 918 kB 918 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 918 kB 918 kB ✓
link.js 976 kB 976 kB ✓
routerDirect.js 969 kB 969 kB ✓
withRouter.js 969 kB 969 kB ✓
Overall change 4.76 MB 4.76 MB ✓
Commit: 74463ca

@vercel vercel bot temporarily deployed to Preview November 16, 2020 14:52 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary PaulPCIO/next.js patch-5 Change
buildDuration 13.5s 13.1s -470ms
nodeModulesSize 85 MB 85 MB ⚠️ +10 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary PaulPCIO/next.js patch-5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.396 2.488 ⚠️ +0.09
/ avg req/sec 1043.3 1004.85 ⚠️ -38.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.268 1.266 0
/error-in-render avg req/sec 1971.3 1975.07 +3.77
Client Bundles (main, webpack, commons)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..776c.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-95c0df2..6c91.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..dule.js gzip 8.26 kB 8.26 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8ead8dd..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary PaulPCIO/next.js patch-5 Change
index.html gzip 968 B 968 B ✓
link.html gzip 974 B 974 B ✓
withRouter.html gzip 961 B 961 B ✓
Overall change 2.9 kB 2.9 kB ✓
Serverless Mode
General
vercel/next.js canary PaulPCIO/next.js patch-5 Change
buildDuration 14.9s 14.9s ⚠️ +5ms
nodeModulesSize 85 MB 85 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..776c.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-95c0df2..6c91.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..dule.js gzip 8.26 kB 8.26 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8ead8dd..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_error.js 918 kB 918 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 918 kB 918 kB ✓
link.js 976 kB 976 kB ✓
routerDirect.js 969 kB 969 kB ✓
withRouter.js 969 kB 969 kB ✓
Overall change 4.76 MB 4.76 MB ✓
Commit: f8bfbfd

@ijjk
Copy link
Member

ijjk commented Nov 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary PaulPCIO/next.js patch-5 Change
buildDuration 14.9s 15.1s ⚠️ +276ms
nodeModulesSize 85 MB 85 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary PaulPCIO/next.js patch-5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.784 2.781 0
/ avg req/sec 897.97 899.07 +1.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.649 1.669 ⚠️ +0.02
/error-in-render avg req/sec 1516.29 1497.58 ⚠️ -18.71
Client Bundles (main, webpack, commons)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..776c.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-95c0df2..6c91.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..dule.js gzip 8.26 kB 8.26 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8ead8dd..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary PaulPCIO/next.js patch-5 Change
index.html gzip 968 B 968 B ✓
link.html gzip 974 B 974 B ✓
withRouter.html gzip 961 B 961 B ✓
Overall change 2.9 kB 2.9 kB ✓
Serverless Mode
General
vercel/next.js canary PaulPCIO/next.js patch-5 Change
buildDuration 17.4s 17.4s ⚠️ +31ms
nodeModulesSize 85 MB 85 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..776c.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-95c0df2..6c91.js gzip 6.53 kB 6.53 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
677f882d2ed8..dule.js gzip 8.26 kB 8.26 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8ead8dd..dule.js gzip 5.64 kB 5.64 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PaulPCIO/next.js patch-5 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary PaulPCIO/next.js patch-5 Change
_error.js 918 kB 918 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 918 kB 918 kB ✓
link.js 976 kB 976 kB ✓
routerDirect.js 969 kB 969 kB ✓
withRouter.js 969 kB 969 kB ✓
Overall change 4.76 MB 4.76 MB ✓
Commit: a341a6c

@kodiakhq kodiakhq bot merged commit feb10f4 into vercel:canary Nov 16, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paul-vd @ijjk @Timer @leerob