Update next/link docs to not include example without href
#19247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfades
requested review from
chibicode,
ijjk,
Timer and
timneutkens
as code owners
Timer
previously approved these changes
Nov 17, 2020
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.289 | 2.283 | -0.01 |
| / avg req/sec | 1092.35 | 1095.21 | +2.86 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.392 | 1.407 | |
| /error-in-render avg req/sec | 1795.72 | 1777.06 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| 677f882d2ed8..776c.js gzip | 12.7 kB | 12.7 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-95c0df2..6c91.js gzip | 6.53 kB | 6.53 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 58.9 kB | 58.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| 677f882d2ed8..dule.js gzip | 8.26 kB | 8.26 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| main-8ead8dd..dule.js gzip | 5.64 kB | 5.64 kB | ✓ |
| webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
| Overall change | 53.6 kB | 53.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _app-3b0cf13..85f8.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-6f635..c393.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4ffc3..9e0f.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-b618194..5477.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Pages Modern
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
| _error-f2fcc..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
| hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
| index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
| link-9741e7f..dule.js gzip | 1.55 kB | 1.55 kB | ✓ |
| routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
| withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 5.64 kB | 5.64 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| _buildManife..dule.js gzip | 329 B | 329 B | ✓ |
| Overall change | 650 B | 650 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| index.html gzip | 968 B | 968 B | ✓ |
| link.html gzip | 975 B | 975 B | ✓ |
| withRouter.html gzip | 961 B | 961 B | ✓ |
| Overall change | 2.9 kB | 2.9 kB | ✓ |
Serverless Mode
General
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| buildDuration | 13.6s | 13.6s | |
| nodeModulesSize | 85 MB | 85 MB | ✓ |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| 677f882d2ed8..776c.js gzip | 12.7 kB | 12.7 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-95c0df2..6c91.js gzip | 6.53 kB | 6.53 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 58.9 kB | 58.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| 677f882d2ed8..dule.js gzip | 8.26 kB | 8.26 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| main-8ead8dd..dule.js gzip | 5.64 kB | 5.64 kB | ✓ |
| webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
| Overall change | 53.6 kB | 53.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _app-3b0cf13..85f8.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-6f635..c393.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4ffc3..9e0f.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-b618194..5477.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Pages Modern
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
| _error-f2fcc..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
| hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
| index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
| link-9741e7f..dule.js gzip | 1.55 kB | 1.55 kB | ✓ |
| routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
| withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 5.64 kB | 5.64 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| _buildManife..dule.js gzip | 329 B | 329 B | ✓ |
| Overall change | 650 B | 650 B | ✓ |
Serverless bundles
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _error.js | 918 kB | 918 kB | ✓ |
| 404.html | 4.61 kB | 4.61 kB | ✓ |
| hooks.html | 3.86 kB | 3.86 kB | ✓ |
| index.js | 918 kB | 918 kB | ✓ |
| link.js | 977 kB | 977 kB | ✓ |
| routerDirect.js | 969 kB | 969 kB | ✓ |
| withRouter.js | 969 kB | 969 kB | ✓ |
| Overall change | 4.76 MB | 4.76 MB | ✓ |
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.438 | 2.422 | -0.02 |
| / avg req/sec | 1025.62 | 1032.17 | +6.55 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.266 | 1.285 | |
| /error-in-render avg req/sec | 1974.58 | 1946.11 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| 677f882d2ed8..776c.js gzip | 12.7 kB | 12.7 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-95c0df2..6c91.js gzip | 6.53 kB | 6.53 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 58.9 kB | 58.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| 677f882d2ed8..dule.js gzip | 8.26 kB | 8.26 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| main-8ead8dd..dule.js gzip | 5.64 kB | 5.64 kB | ✓ |
| webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
| Overall change | 53.6 kB | 53.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _app-3b0cf13..85f8.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-6f635..c393.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4ffc3..9e0f.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-b618194..5477.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Pages Modern
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
| _error-f2fcc..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
| hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
| index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
| link-9741e7f..dule.js gzip | 1.55 kB | 1.55 kB | ✓ |
| routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
| withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 5.64 kB | 5.64 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| _buildManife..dule.js gzip | 329 B | 329 B | ✓ |
| Overall change | 650 B | 650 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| index.html gzip | 968 B | 968 B | ✓ |
| link.html gzip | 975 B | 975 B | ✓ |
| withRouter.html gzip | 961 B | 961 B | ✓ |
| Overall change | 2.9 kB | 2.9 kB | ✓ |
Serverless Mode
General
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| buildDuration | 15.4s | 15.3s | -131ms |
| nodeModulesSize | 85 MB | 85 MB | ✓ |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| 677f882d2ed8..776c.js gzip | 12.7 kB | 12.7 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-95c0df2..6c91.js gzip | 6.53 kB | 6.53 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 58.9 kB | 58.9 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| 677f882d2ed8..dule.js gzip | 8.26 kB | 8.26 kB | ✓ |
| framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
| main-8ead8dd..dule.js gzip | 5.64 kB | 5.64 kB | ✓ |
| webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
| Overall change | 53.6 kB | 53.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _app-3b0cf13..85f8.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-6f635..c393.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4ffc3..9e0f.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-b618194..5477.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Pages Modern
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
| _error-f2fcc..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
| hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
| index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
| link-9741e7f..dule.js gzip | 1.55 kB | 1.55 kB | ✓ |
| routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
| withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
| Overall change | 5.64 kB | 5.64 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| _buildManife..dule.js gzip | 329 B | 329 B | ✓ |
| Overall change | 650 B | 650 B | ✓ |
Serverless bundles
| vercel/next.js canary | lfades/next.js don-t-recommend-the-usage-of-next-link-without-ch15296 | Change | |
|---|---|---|---|
| _error.js | 918 kB | 918 kB | ✓ |
| 404.html | 4.61 kB | 4.61 kB | ✓ |
| hooks.html | 3.86 kB | 3.86 kB | ✓ |
| index.js | 918 kB | 918 kB | ✓ |
| link.js | 977 kB | 977 kB | ✓ |
| routerDirect.js | 969 kB | 969 kB | ✓ |
| withRouter.js | 969 kB | 969 kB | ✓ |
| Overall change | 4.76 MB | 4.76 MB | ✓ |
… of https://github.com/lfades/next.js into don-t-recommend-the-usage-of-next-link-without-ch15296
timneutkens
approved these changes
Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19245