Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs and Create Next App to use API Middlewares by default. #21639

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Update docs and Create Next App to use API Middlewares by default. #21639

merged 2 commits into from
Jan 28, 2021

Conversation

leerob
Copy link
Member

@leerob leerob commented Jan 28, 2021

No description provided.

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue was opened via the examples template. labels Jan 28, 2021
@ijjk
Copy link
Member

ijjk commented Jan 28, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary leerob/next.js api-middlewares Change
buildDuration 10.4s 10.7s ⚠️ +309ms
nodeModulesSize 75 MB 75 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary leerob/next.js api-middlewares Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.046 2.053 ⚠️ +0.01
/ avg req/sec 1222.13 1217.94 ⚠️ -4.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.321 1.277 -0.04
/error-in-render avg req/sec 1892.62 1957.52 +64.9
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js api-middlewares Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js api-middlewares Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary leerob/next.js api-middlewares Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js api-middlewares Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js api-middlewares Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary leerob/next.js api-middlewares Change
buildDuration 12.4s 12.4s -47ms
nodeModulesSize 75 MB 75 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js api-middlewares Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js api-middlewares Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary leerob/next.js api-middlewares Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js api-middlewares Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary leerob/next.js api-middlewares Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary leerob/next.js api-middlewares Change
buildDuration 12.6s 12.6s ⚠️ +8ms
nodeModulesSize 75 MB 75 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary leerob/next.js api-middlewares Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.09 2.046 -0.04
/ avg req/sec 1196.34 1222.17 +25.83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.282 1.272 -0.01
/error-in-render avg req/sec 1949.55 1965.94 +16.39
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js api-middlewares Change
597-7c719119..27b6.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js api-middlewares Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary leerob/next.js api-middlewares Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js api-middlewares Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js api-middlewares Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 579 B 579 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "9DlGOqPBt0mu0EhY6clip",
+        "buildId": "fDXZ2E_GMY1DmzN3I0By-",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/9DlGOqPBt0mu0EhY6clip/_buildManifest.js"
+      src="/_next/static/fDXZ2E_GMY1DmzN3I0By-/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/9DlGOqPBt0mu0EhY6clip/_ssgManifest.js"
+      src="/_next/static/fDXZ2E_GMY1DmzN3I0By-/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "9DlGOqPBt0mu0EhY6clip",
+        "buildId": "fDXZ2E_GMY1DmzN3I0By-",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/9DlGOqPBt0mu0EhY6clip/_buildManifest.js"
+      src="/_next/static/fDXZ2E_GMY1DmzN3I0By-/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/9DlGOqPBt0mu0EhY6clip/_ssgManifest.js"
+      src="/_next/static/fDXZ2E_GMY1DmzN3I0By-/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "9DlGOqPBt0mu0EhY6clip",
+        "buildId": "fDXZ2E_GMY1DmzN3I0By-",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/9DlGOqPBt0mu0EhY6clip/_buildManifest.js"
+      src="/_next/static/fDXZ2E_GMY1DmzN3I0By-/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/9DlGOqPBt0mu0EhY6clip/_ssgManifest.js"
+      src="/_next/static/fDXZ2E_GMY1DmzN3I0By-/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 66a1187

@ijjk
Copy link
Member

ijjk commented Jan 28, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary leerob/next.js api-middlewares Change
buildDuration 9.1s 9s -169ms
nodeModulesSize 75 MB 75 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary leerob/next.js api-middlewares Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.723 1.755 ⚠️ +0.03
/ avg req/sec 1451.35 1424.38 ⚠️ -26.97
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.099 1.101 0
/error-in-render avg req/sec 2275.82 2270.89 ⚠️ -4.93
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js api-middlewares Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js api-middlewares Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary leerob/next.js api-middlewares Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js api-middlewares Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js api-middlewares Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary leerob/next.js api-middlewares Change
buildDuration 10.5s 10.9s ⚠️ +409ms
nodeModulesSize 75 MB 75 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js api-middlewares Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js api-middlewares Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary leerob/next.js api-middlewares Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js api-middlewares Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary leerob/next.js api-middlewares Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary leerob/next.js api-middlewares Change
buildDuration 10.7s 10.8s ⚠️ +30ms
nodeModulesSize 75 MB 75 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary leerob/next.js api-middlewares Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.74 1.729 -0.01
/ avg req/sec 1436.96 1446.13 +9.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.132 1.109 -0.02
/error-in-render avg req/sec 2209 2253.43 +44.43
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js api-middlewares Change
597-7c719119..27b6.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js api-middlewares Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary leerob/next.js api-middlewares Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js api-middlewares Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js api-middlewares Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 579 B 579 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "PojinKVNauL7O26alhMIz",
+        "buildId": "ebjNQogcFpkL0QFcZKft1",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/PojinKVNauL7O26alhMIz/_buildManifest.js"
+      src="/_next/static/ebjNQogcFpkL0QFcZKft1/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/PojinKVNauL7O26alhMIz/_ssgManifest.js"
+      src="/_next/static/ebjNQogcFpkL0QFcZKft1/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "PojinKVNauL7O26alhMIz",
+        "buildId": "ebjNQogcFpkL0QFcZKft1",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/PojinKVNauL7O26alhMIz/_buildManifest.js"
+      src="/_next/static/ebjNQogcFpkL0QFcZKft1/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/PojinKVNauL7O26alhMIz/_ssgManifest.js"
+      src="/_next/static/ebjNQogcFpkL0QFcZKft1/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "PojinKVNauL7O26alhMIz",
+        "buildId": "ebjNQogcFpkL0QFcZKft1",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/PojinKVNauL7O26alhMIz/_buildManifest.js"
+      src="/_next/static/ebjNQogcFpkL0QFcZKft1/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/PojinKVNauL7O26alhMIz/_ssgManifest.js"
+      src="/_next/static/ebjNQogcFpkL0QFcZKft1/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 1f15540

@kodiakhq kodiakhq bot merged commit 5a73859 into vercel:canary Jan 28, 2021
This was referenced Jan 29, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 14, 2021
Open
Open
Open
Open
Open
Open
This was referenced Aug 3, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 31, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 9, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 16, 2021
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leerob @ijjk