Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about preloading to routing introduction. #22656

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Conversation

leerob
Copy link
Member

@leerob leerob commented Mar 2, 2021

Preloading is mentioned in the next/link docs, but not in the routing introduction.

docs/routing/introduction.md Outdated Show resolved Hide resolved
Co-authored-by: JJ Kasper <jj@jjsweb.site>
docs/routing/introduction.md Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit b874bc7 into canary Mar 2, 2021
@kodiakhq kodiakhq bot deleted the leerob-patch-1 branch March 2, 2021 03:17
@stigkj
Copy link
Contributor

stigkj commented Mar 11, 2021

@leerob This change seems to say that prefetching is not done for SSR pages. While the documentation for next/link seems to not be in agreement with this. Or is it just my understanding that is off?? ;-)

@leerob
Copy link
Member Author

leerob commented Mar 11, 2021

Correct - which part needs updated there? I can tackle that 👍

@stigkj
Copy link
Contributor

stigkj commented Mar 12, 2021

I'm not sure what it is supposed to say, because I am not sure what actually happens 😛 Is it prefetching SSR pages? And if that is the case, how (or what)?

@leerob
Copy link
Member Author

leerob commented Mar 12, 2021

SSR routes aren't prefetched, as added in this PR. The next/link docs say this - which part needs more clarity to you?
image

@stigkj
Copy link
Contributor

stigkj commented Mar 19, 2021

I think it should be more explicit, like it is in this PR. I.e. say that SSR pages are not prefetched. As it is now I thought that SSR pages were prefetched, while static pages did some extra stuff for even faster prefetching.

@stigkj
Copy link
Contributor

stigkj commented Mar 19, 2021

And where are the discussion around why SSR pages are not prefetched?

@timneutkens
Copy link
Member

The JS for SSR pages is prefetched. Just not the data.

@stigkj
Copy link
Contributor

stigkj commented Mar 19, 2021

Ok 👍 What is the reason for not prefetching data for SSR pages? Not that it needs to be the default, but having it as an option would be nice.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants