Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure optional params are normalized in minimal mode #22676

Merged
merged 5 commits into from
Mar 2, 2021
Merged

Ensure optional params are normalized in minimal mode #22676

merged 5 commits into from
Mar 2, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 2, 2021

This ensures we correctly omit optional values from the query when in minimal mode. Additional tests to ensure this is handled correctly have been added to ensure we don't regress on this.

Fixes: #15579

@ijjk
Copy link
Member Author

ijjk commented Mar 2, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 12.7s 12.4s -276ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.214 2.203 -0.01
/ avg req/sec 1129.15 1134.71 +5.56
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.379 1.423 ⚠️ +0.04
/error-in-render avg req/sec 1813.48 1756.35 ⚠️ -57.13
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 15s 15.5s ⚠️ +473ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 14.9s 14.7s -236ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.217 2.191 -0.03
/ avg req/sec 1127.45 1140.94 +13.49
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.423 1.339 -0.08
/error-in-render avg req/sec 1757.21 1866.7 +109.49
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.6 kB 6.6 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 586 B 586 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "v8HuP4p4sYMbMpHXiHRAz",
+        "buildId": "X3iGdSPnlQMGK4D7R4-dl",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/v8HuP4p4sYMbMpHXiHRAz/_buildManifest.js"
+      src="/_next/static/X3iGdSPnlQMGK4D7R4-dl/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/v8HuP4p4sYMbMpHXiHRAz/_ssgManifest.js"
+      src="/_next/static/X3iGdSPnlQMGK4D7R4-dl/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "v8HuP4p4sYMbMpHXiHRAz",
+        "buildId": "X3iGdSPnlQMGK4D7R4-dl",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/v8HuP4p4sYMbMpHXiHRAz/_buildManifest.js"
+      src="/_next/static/X3iGdSPnlQMGK4D7R4-dl/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/v8HuP4p4sYMbMpHXiHRAz/_ssgManifest.js"
+      src="/_next/static/X3iGdSPnlQMGK4D7R4-dl/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "v8HuP4p4sYMbMpHXiHRAz",
+        "buildId": "X3iGdSPnlQMGK4D7R4-dl",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/v8HuP4p4sYMbMpHXiHRAz/_buildManifest.js"
+      src="/_next/static/X3iGdSPnlQMGK4D7R4-dl/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/v8HuP4p4sYMbMpHXiHRAz/_ssgManifest.js"
+      src="/_next/static/X3iGdSPnlQMGK4D7R4-dl/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: f1091a1

@ijjk
Copy link
Member Author

ijjk commented Mar 2, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 11.1s 11.3s ⚠️ +265ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.004 1.964 -0.04
/ avg req/sec 1247.36 1273.03 +25.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.249 1.318 ⚠️ +0.07
/error-in-render avg req/sec 2001.94 1896.54 ⚠️ -105.4
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 13.6s 13.8s ⚠️ +237ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 13.4s 12.9s -449ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.966 1.955 -0.01
/ avg req/sec 1271.9 1278.68 +6.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.245 1.233 -0.01
/error-in-render avg req/sec 2007.76 2027.65 +19.89
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.6 kB 6.6 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 586 B 586 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "5QZGSWdc5ymt9lteNSIGJ",
+        "buildId": "cVxHIWnQRsHRzYtDCTJx5",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/5QZGSWdc5ymt9lteNSIGJ/_buildManifest.js"
+      src="/_next/static/cVxHIWnQRsHRzYtDCTJx5/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/5QZGSWdc5ymt9lteNSIGJ/_ssgManifest.js"
+      src="/_next/static/cVxHIWnQRsHRzYtDCTJx5/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "5QZGSWdc5ymt9lteNSIGJ",
+        "buildId": "cVxHIWnQRsHRzYtDCTJx5",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/5QZGSWdc5ymt9lteNSIGJ/_buildManifest.js"
+      src="/_next/static/cVxHIWnQRsHRzYtDCTJx5/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/5QZGSWdc5ymt9lteNSIGJ/_ssgManifest.js"
+      src="/_next/static/cVxHIWnQRsHRzYtDCTJx5/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "5QZGSWdc5ymt9lteNSIGJ",
+        "buildId": "cVxHIWnQRsHRzYtDCTJx5",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/5QZGSWdc5ymt9lteNSIGJ/_buildManifest.js"
+      src="/_next/static/cVxHIWnQRsHRzYtDCTJx5/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/5QZGSWdc5ymt9lteNSIGJ/_ssgManifest.js"
+      src="/_next/static/cVxHIWnQRsHRzYtDCTJx5/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 68a6d89

@ijjk
Copy link
Member Author

ijjk commented Mar 2, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 10s 9.9s -83ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.721 1.724 0
/ avg req/sec 1452.25 1450.02 ⚠️ -2.23
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.082 1.086 0
/error-in-render avg req/sec 2310.14 2301.09 ⚠️ -9.05
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 11.6s 11.6s -3ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 11.4s 11.4s ⚠️ +10ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.75 1.688 -0.06
/ avg req/sec 1428.91 1481.44 +52.53
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.091 1.08 -0.01
/error-in-render avg req/sec 2291.28 2314.12 +22.84
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.6 kB 6.6 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 586 B 586 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "lLokTGTCBkuCWgnV03HMC",
+        "buildId": "AmrL-c6Nbm-zYjrQ9Qol4",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/lLokTGTCBkuCWgnV03HMC/_buildManifest.js"
+      src="/_next/static/AmrL-c6Nbm-zYjrQ9Qol4/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/lLokTGTCBkuCWgnV03HMC/_ssgManifest.js"
+      src="/_next/static/AmrL-c6Nbm-zYjrQ9Qol4/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "lLokTGTCBkuCWgnV03HMC",
+        "buildId": "AmrL-c6Nbm-zYjrQ9Qol4",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/lLokTGTCBkuCWgnV03HMC/_buildManifest.js"
+      src="/_next/static/AmrL-c6Nbm-zYjrQ9Qol4/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/lLokTGTCBkuCWgnV03HMC/_ssgManifest.js"
+      src="/_next/static/AmrL-c6Nbm-zYjrQ9Qol4/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "lLokTGTCBkuCWgnV03HMC",
+        "buildId": "AmrL-c6Nbm-zYjrQ9Qol4",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/lLokTGTCBkuCWgnV03HMC/_buildManifest.js"
+      src="/_next/static/AmrL-c6Nbm-zYjrQ9Qol4/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/lLokTGTCBkuCWgnV03HMC/_ssgManifest.js"
+      src="/_next/static/AmrL-c6Nbm-zYjrQ9Qol4/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 57afeda

@ijjk
Copy link
Member Author

ijjk commented Mar 2, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 12.1s 12.3s ⚠️ +188ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.024 2.119 ⚠️ +0.1
/ avg req/sec 1235.02 1179.86 ⚠️ -55.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.309 1.369 ⚠️ +0.06
/error-in-render avg req/sec 1909.28 1825.64 ⚠️ -83.64
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 14.6s 14.1s -441ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_error.js 1.01 MB 1.01 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.01 MB 1.01 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.21 MB 5.21 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 13.9s 13.9s -42ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.069 2.125 ⚠️ +0.06
/ avg req/sec 1208.23 1176.57 ⚠️ -31.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.344 1.312 -0.03
/error-in-render avg req/sec 1859.68 1905.1 +45.42
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.6 kB 6.6 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 586 B 586 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "8wPuGUPTfcYpY8p7NQ3Xn",
+        "buildId": "WZZsQezVSVjHYqZAee9-V",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8wPuGUPTfcYpY8p7NQ3Xn/_buildManifest.js"
+      src="/_next/static/WZZsQezVSVjHYqZAee9-V/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8wPuGUPTfcYpY8p7NQ3Xn/_ssgManifest.js"
+      src="/_next/static/WZZsQezVSVjHYqZAee9-V/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "8wPuGUPTfcYpY8p7NQ3Xn",
+        "buildId": "WZZsQezVSVjHYqZAee9-V",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8wPuGUPTfcYpY8p7NQ3Xn/_buildManifest.js"
+      src="/_next/static/WZZsQezVSVjHYqZAee9-V/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8wPuGUPTfcYpY8p7NQ3Xn/_ssgManifest.js"
+      src="/_next/static/WZZsQezVSVjHYqZAee9-V/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "8wPuGUPTfcYpY8p7NQ3Xn",
+        "buildId": "WZZsQezVSVjHYqZAee9-V",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8wPuGUPTfcYpY8p7NQ3Xn/_buildManifest.js"
+      src="/_next/static/WZZsQezVSVjHYqZAee9-V/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8wPuGUPTfcYpY8p7NQ3Xn/_ssgManifest.js"
+      src="/_next/static/WZZsQezVSVjHYqZAee9-V/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 2a42ac7

@ijjk
Copy link
Member Author

ijjk commented Mar 2, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 11.9s 11.8s -128ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.039 2.021 -0.02
/ avg req/sec 1225.83 1236.83 +11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.269 1.321 ⚠️ +0.05
/error-in-render avg req/sec 1970.28 1892.59 ⚠️ -77.69
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 14.5s 14.1s -394ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
677f882d2ed8..e7a0.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.4 kB 10.4 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
buildDuration 13.9s 14s ⚠️ +132ms
nodeModulesSize 42.7 MB 42.7 MB ⚠️ +51 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.011 2.011 ✓
/ avg req/sec 1243.34 1243.46 +0.12
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.347 1.33 -0.02
/error-in-render avg req/sec 1856.42 1880.02 +23.6
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
597-74632e79..1d47.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.6 kB 6.6 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.1 kB 60.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/optional-query-params-normalizing Change
index.html gzip 587 B 587 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "HPFNMdTNgme3W19PMJM44",
+        "buildId": "HD1Kv6khRRYUsOCutSNTj",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/HPFNMdTNgme3W19PMJM44/_buildManifest.js"
+      src="/_next/static/HD1Kv6khRRYUsOCutSNTj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/HPFNMdTNgme3W19PMJM44/_ssgManifest.js"
+      src="/_next/static/HD1Kv6khRRYUsOCutSNTj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "HPFNMdTNgme3W19PMJM44",
+        "buildId": "HD1Kv6khRRYUsOCutSNTj",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/HPFNMdTNgme3W19PMJM44/_buildManifest.js"
+      src="/_next/static/HD1Kv6khRRYUsOCutSNTj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/HPFNMdTNgme3W19PMJM44/_ssgManifest.js"
+      src="/_next/static/HD1Kv6khRRYUsOCutSNTj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "HPFNMdTNgme3W19PMJM44",
+        "buildId": "HD1Kv6khRRYUsOCutSNTj",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/HPFNMdTNgme3W19PMJM44/_buildManifest.js"
+      src="/_next/static/HD1Kv6khRRYUsOCutSNTj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/HPFNMdTNgme3W19PMJM44/_ssgManifest.js"
+      src="/_next/static/HD1Kv6khRRYUsOCutSNTj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: e54c5fb

@ijjk ijjk merged commit e037c22 into vercel:canary Mar 2, 2021
@ijjk ijjk deleted the fix/optional-query-params-normalizing branch March 2, 2021 19:51
@ijjk ijjk added the type: next label Mar 3, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
2 participants
@ijjk @timneutkens