Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message for next export and next/image. #23061

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Update error message for next export and next/image. #23061

merged 2 commits into from
Mar 15, 2021

Conversation

leerob
Copy link
Member

@leerob leerob commented Mar 14, 2021

This wasn't reflecting the new loader prop for next/image.

@ijjk
Copy link
Member

ijjk commented Mar 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary leerob/next.js update-docs-export-image Change
buildDuration 12.7s 12.5s -165ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +164 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary leerob/next.js update-docs-export-image Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.286 2.322 ⚠️ +0.04
/ avg req/sec 1093.61 1076.57 ⚠️ -17.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.636 1.624 -0.01
/error-in-render avg req/sec 1527.92 1538.96 +11.04
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js update-docs-export-image Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.67 kB 6.67 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js update-docs-export-image Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary leerob/next.js update-docs-export-image Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c0d2c96..de48.js gzip 1.67 kB 1.67 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js update-docs-export-image Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js update-docs-export-image Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary leerob/next.js update-docs-export-image Change
buildDuration 14.7s 15.1s ⚠️ +426ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +164 B
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js update-docs-export-image Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.67 kB 6.67 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js update-docs-export-image Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary leerob/next.js update-docs-export-image Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c0d2c96..de48.js gzip 1.67 kB 1.67 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js update-docs-export-image Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary leerob/next.js update-docs-export-image Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary leerob/next.js update-docs-export-image Change
buildDuration 15s 15.4s ⚠️ +405ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +164 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary leerob/next.js update-docs-export-image Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.323 2.387 ⚠️ +0.06
/ avg req/sec 1076.04 1047.54 ⚠️ -28.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.565 1.587 ⚠️ +0.02
/error-in-render avg req/sec 1596.97 1575.14 ⚠️ -21.83
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js update-docs-export-image Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.62 kB 6.62 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js update-docs-export-image Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary leerob/next.js update-docs-export-image Change
_app-0c62a59..94b7.js gzip 1.26 kB 1.26 kB ✓
_error-97d24..ed28.js gzip 3.38 kB 3.38 kB ✓
amp-2926e4c2..9ccc.js gzip 536 B 536 B ✓
hooks-1ed65b..8908.js gzip 902 B 902 B ✓
index-6259b6..77d8.js gzip 230 B 230 B ✓
link-b722682..14a4.js gzip 1.65 kB 1.65 kB ✓
routerDirect..862a.js gzip 306 B 306 B ✓
withRouter-4..76fd.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js update-docs-export-image Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js update-docs-export-image Change
index.html gzip 587 B 587 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "6kodhEgGJLQ0zyvvXl0cl",
+        "buildId": "FFRRvaKraj5ol6lvfDrG7",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/6kodhEgGJLQ0zyvvXl0cl/_buildManifest.js"
+      src="/_next/static/FFRRvaKraj5ol6lvfDrG7/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/6kodhEgGJLQ0zyvvXl0cl/_ssgManifest.js"
+      src="/_next/static/FFRRvaKraj5ol6lvfDrG7/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "6kodhEgGJLQ0zyvvXl0cl",
+        "buildId": "FFRRvaKraj5ol6lvfDrG7",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/6kodhEgGJLQ0zyvvXl0cl/_buildManifest.js"
+      src="/_next/static/FFRRvaKraj5ol6lvfDrG7/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/6kodhEgGJLQ0zyvvXl0cl/_ssgManifest.js"
+      src="/_next/static/FFRRvaKraj5ol6lvfDrG7/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "6kodhEgGJLQ0zyvvXl0cl",
+        "buildId": "FFRRvaKraj5ol6lvfDrG7",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/6kodhEgGJLQ0zyvvXl0cl/_buildManifest.js"
+      src="/_next/static/FFRRvaKraj5ol6lvfDrG7/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/6kodhEgGJLQ0zyvvXl0cl/_ssgManifest.js"
+      src="/_next/static/FFRRvaKraj5ol6lvfDrG7/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 0949980

@ijjk
Copy link
Member

ijjk commented Mar 15, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary leerob/next.js update-docs-export-image Change
buildDuration 11.9s 12.1s ⚠️ +239ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +164 B
Page Load Tests Overall increase ✓
vercel/next.js canary leerob/next.js update-docs-export-image Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.289 2.304 ⚠️ +0.01
/ avg req/sec 1092.04 1085.18 ⚠️ -6.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.557 1.476 -0.08
/error-in-render avg req/sec 1605.87 1693.44 +87.57
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js update-docs-export-image Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.67 kB 6.67 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js update-docs-export-image Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary leerob/next.js update-docs-export-image Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c0d2c96..de48.js gzip 1.67 kB 1.67 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js update-docs-export-image Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js update-docs-export-image Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary leerob/next.js update-docs-export-image Change
buildDuration 14.5s 14.1s -425ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +164 B
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js update-docs-export-image Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.67 kB 6.67 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js update-docs-export-image Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary leerob/next.js update-docs-export-image Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c0d2c96..de48.js gzip 1.67 kB 1.67 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js update-docs-export-image Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary leerob/next.js update-docs-export-image Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary leerob/next.js update-docs-export-image Change
buildDuration 14.3s 14.2s -58ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +164 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary leerob/next.js update-docs-export-image Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.106 2.351 ⚠️ +0.25
/ avg req/sec 1187.02 1063.5 ⚠️ -123.52
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.42 1.65 ⚠️ +0.23
/error-in-render avg req/sec 1760.5 1514.72 ⚠️ -245.78
Client Bundles (main, webpack, commons)
vercel/next.js canary leerob/next.js update-docs-export-image Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.62 kB 6.62 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary leerob/next.js update-docs-export-image Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary leerob/next.js update-docs-export-image Change
_app-0c62a59..94b7.js gzip 1.26 kB 1.26 kB ✓
_error-97d24..ed28.js gzip 3.38 kB 3.38 kB ✓
amp-2926e4c2..9ccc.js gzip 536 B 536 B ✓
hooks-1ed65b..8908.js gzip 902 B 902 B ✓
index-6259b6..77d8.js gzip 230 B 230 B ✓
link-b722682..14a4.js gzip 1.65 kB 1.65 kB ✓
routerDirect..862a.js gzip 306 B 306 B ✓
withRouter-4..76fd.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary leerob/next.js update-docs-export-image Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary leerob/next.js update-docs-export-image Change
index.html gzip 587 B 587 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "EPWuKDzavmoe6G3xUo23s",
+        "buildId": "OCVyVqlYksmeJEprb_xp5",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/EPWuKDzavmoe6G3xUo23s/_buildManifest.js"
+      src="/_next/static/OCVyVqlYksmeJEprb_xp5/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/EPWuKDzavmoe6G3xUo23s/_ssgManifest.js"
+      src="/_next/static/OCVyVqlYksmeJEprb_xp5/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "EPWuKDzavmoe6G3xUo23s",
+        "buildId": "OCVyVqlYksmeJEprb_xp5",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/EPWuKDzavmoe6G3xUo23s/_buildManifest.js"
+      src="/_next/static/OCVyVqlYksmeJEprb_xp5/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/EPWuKDzavmoe6G3xUo23s/_ssgManifest.js"
+      src="/_next/static/OCVyVqlYksmeJEprb_xp5/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "EPWuKDzavmoe6G3xUo23s",
+        "buildId": "OCVyVqlYksmeJEprb_xp5",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/EPWuKDzavmoe6G3xUo23s/_buildManifest.js"
+      src="/_next/static/OCVyVqlYksmeJEprb_xp5/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/EPWuKDzavmoe6G3xUo23s/_ssgManifest.js"
+      src="/_next/static/OCVyVqlYksmeJEprb_xp5/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 5c479e1

@ijjk ijjk merged commit a63c64a into vercel:canary Mar 15, 2021
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
This was referenced Mar 16, 2021
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leerob @ijjk