Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the text for eslint/no-page-custom-font rule #25117

Merged
merged 6 commits into from
May 19, 2021

Conversation

rgabs
Copy link
Contributor

@rgabs rgabs commented May 13, 2021

Documentation / Examples

  • Make sure the linting passes

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented May 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
buildDuration 11.6s 11.6s ⚠️ +24ms
buildDurationCached 3.5s 3.5s -38ms
nodeModulesSize 46.7 MB 46.7 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
/ failed reqs 0 0
/ total time (seconds) 2.035 2.079 ⚠️ +0.04
/ avg req/sec 1228.39 1202.36 ⚠️ -26.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.084 1.085 0
/error-in-render avg req/sec 2306.22 2304.04 ⚠️ -2.18
Client Bundles (main, webpack, commons)
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
index.html gzip 561 B 561 B
link.html gzip 569 B 569 B
withRouter.html gzip 557 B 557 B
Overall change 1.69 kB 1.69 kB

Serverless Mode
General
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
buildDuration 13.5s 13.7s ⚠️ +147ms
buildDurationCached 4.5s 4.4s -86ms
nodeModulesSize 46.7 MB 46.7 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Serverless bundles
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
_error.js 16.9 kB 16.9 kB
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 17.2 kB 17.2 kB
link.js 17.4 kB 17.4 kB
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB
Overall change 107 kB 107 kB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
buildDuration 10.6s 10.7s ⚠️ +16ms
buildDurationCached 4.5s 4.5s -61ms
nodeModulesSize 46.7 MB 46.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
/ failed reqs 0 0
/ total time (seconds) 2.138 2.119 -0.02
/ avg req/sec 1169.25 1180.05 +10.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.147 1.102 -0.04
/error-in-render avg req/sec 2180.5 2269.24 +88.74
Client Bundles (main, webpack, commons)
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.26 kB 7.26 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.38 kB 9.38 kB
Client Build Manifests
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary rgabs/next.js eslint/no-page-custom-font-text-update Change
index.html gzip 612 B 612 B
link.html gzip 620 B 620 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB
Commit: db1e9c5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants