Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postcss-loader to 4.3.0 #25197

Merged
merged 5 commits into from
May 19, 2021
Merged

Conversation

bradlc
Copy link
Contributor

@bradlc bradlc commented May 17, 2021

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

This pull request upgrades postcss-loader from 4.0.3 to 4.3.0. Version 4.3.0 adds support for the dir-dependency message type which PostCSS plugins can use to register directories as dependencies (documentation).

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented May 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
buildDuration 16.1s 15.4s -788ms
buildDurationCached 4.6s 4.7s ⚠️ +90ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +307 B
Page Load Tests Overall increase ✓
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
/ failed reqs 0 0
/ total time (seconds) 2.689 2.666 -0.02
/ avg req/sec 929.57 937.75 +8.18
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.558 1.557 0
/error-in-render avg req/sec 1605.09 1605.93 +0.84
Client Bundles (main, webpack, commons)
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
index.html gzip 559 B 559 B
link.html gzip 569 B 569 B
withRouter.html gzip 556 B 556 B
Overall change 1.68 kB 1.68 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
buildDuration 18s 18.8s ⚠️ +837ms
buildDurationCached 5.6s 5.7s ⚠️ +112ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +307 B
Client Bundles (main, webpack, commons)
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Serverless bundles Overall decrease ✓
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
_error.js 16.9 kB 16.9 kB -2 B
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 17.2 kB 17.2 kB
link.js 17.4 kB 17.4 kB
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB
Overall change 107 kB 107 kB -2 B

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
buildDuration 12.9s 13.6s ⚠️ +669ms
buildDurationCached 5.6s 5.5s -171ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +307 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
/ failed reqs 0 0
/ total time (seconds) 2.71 2.795 ⚠️ +0.08
/ avg req/sec 922.5 894.36 ⚠️ -28.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.584 1.614 ⚠️ +0.03
/error-in-render avg req/sec 1578.51 1548.61 ⚠️ -29.9
Client Bundles (main, webpack, commons)
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.25 kB 7.25 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.38 kB 9.38 kB
Client Build Manifests
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary bradlc/next.js postcss-loader/upgrade Change
index.html gzip 614 B 614 B
link.html gzip 621 B 621 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB
Commit: 77d83ac

@kodiakhq kodiakhq bot merged commit ea1cdb2 into vercel:canary May 19, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

This pull request upgrades `postcss-loader` from `4.0.3` to `4.3.0`. Version `4.3.0` [adds support](webpack-contrib/postcss-loader#525) for the `dir-dependency` message type which PostCSS plugins can use to register directories as dependencies ([documentation](https://github.com/postcss/postcss/blob/main/docs/guidelines/plugin.md#31-use-messages-to-specify-dependencies)).
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants