Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-loadable-plugin. Handle undefined opts.caller #25264

Merged
merged 2 commits into from
May 19, 2021
Merged

react-loadable-plugin. Handle undefined opts.caller #25264

merged 2 commits into from
May 19, 2021

Conversation

SinimaWath
Copy link
Contributor

caller - in babel is optional field - https://babeljs.io/docs/en/options#caller

And it may be not provided by developer in transformFile

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

ijjk
ijjk approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented May 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary SinimaWath/next.js loadable_caller Change
buildDuration 13.4s 13.6s ⚠️ +108ms
buildDurationCached 4s 4s -23ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +88 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary SinimaWath/next.js loadable_caller Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.547 2.5 -0.05
/ avg req/sec 981.47 999.82 +18.35
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.371 1.473 ⚠️ +0.1
/error-in-render avg req/sec 1823.96 1696.94 ⚠️ -127.02
Client Bundles (main, webpack, commons)
vercel/next.js canary SinimaWath/next.js loadable_caller Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary SinimaWath/next.js loadable_caller Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary SinimaWath/next.js loadable_caller Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary SinimaWath/next.js loadable_caller Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary SinimaWath/next.js loadable_caller Change
index.html gzip 559 B 559 B ✓
link.html gzip 569 B 569 B ✓
withRouter.html gzip 556 B 556 B ✓
Overall change 1.68 kB 1.68 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary SinimaWath/next.js loadable_caller Change
buildDuration 15.7s 15.6s -126ms
buildDurationCached 4.9s 5.1s ⚠️ +203ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +88 B
Client Bundles (main, webpack, commons)
vercel/next.js canary SinimaWath/next.js loadable_caller Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary SinimaWath/next.js loadable_caller Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary SinimaWath/next.js loadable_caller Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary SinimaWath/next.js loadable_caller Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles
vercel/next.js canary SinimaWath/next.js loadable_caller Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB ✓
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary SinimaWath/next.js loadable_caller Change
buildDuration 12.3s 12.3s ⚠️ +33ms
buildDurationCached 5.4s 5.2s -112ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +88 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary SinimaWath/next.js loadable_caller Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.587 2.604 ⚠️ +0.02
/ avg req/sec 966.34 960.07 ⚠️ -6.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.509 1.52 ⚠️ +0.01
/error-in-render avg req/sec 1657.14 1644.7 ⚠️ -12.44
Client Bundles (main, webpack, commons)
vercel/next.js canary SinimaWath/next.js loadable_caller Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.25 kB 7.25 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary SinimaWath/next.js loadable_caller Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary SinimaWath/next.js loadable_caller Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary SinimaWath/next.js loadable_caller Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary SinimaWath/next.js loadable_caller Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 810f2b1

@kodiakhq kodiakhq bot merged commit 935a66d into vercel:canary May 19, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@SinimaWath
react-loadable-plugin. Handle undefined opts.caller (vercel#25264)
ae496bc 
`caller` - in babel is optional field - https://babeljs.io/docs/en/options#caller

And it may be not provided by developer in transformFile

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
This was referenced Jul 29, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 19, 2021
Open
This was referenced Jan 12, 2022
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SinimaWath @ijjk